ARM: Add a postRA pass to legalize stack offsets. Greedy approach (reserve IP).

src/IceTargetLowering.cpp

Index: src/IceTargetLowering.cpp
diff --git a/src/IceTargetLowering.cpp b/src/IceTargetLowering.cpp
index 671bab029d0d30871a55e94f9a27052f27f36a9d..60a77ca5c2baa9fb9cff38f9cba6194a5f98a8bf 100644
--- a/src/IceTargetLowering.cpp
+++ b/src/IceTargetLowering.cpp
@@ -345,6 +345,9 @@ void TargetLowering::getVarStackSlotParams(
       *SpillAreaSizeBytes += Increment;
     }
   }
+  // For testing legalization of large stack offsets on targets with limited
+  // offset bits in instruction encodings, add some padding.
+  *SpillAreaSizeBytes += Ctx->getFlags().getTestStackExtra();
 }
 
 void TargetLowering::alignStackSpillAreas(uint32_t SpillAreaStartOffset,
@@ -376,10 +379,21 @@ void TargetLowering::assignVarStackSlots(VarList &SortedSpilledVariables,
                                          size_t GlobalsAndSubsequentPaddingSize,
                                          bool UsesFramePointer) {
   const VariablesMetadata *VMetadata = Func->getVMetadata();
+  // For testing legalization of large stack offsets on targets with limited
+  // offset bits in instruction encodings, add some padding. This assumes that
+  // SpillAreaSizeBytes has accounted for the extra test padding.
+  // When UseFramePointer is true, the offset depends on the padding,
+  // not just the SpillAreaSizeBytes. On the other hand, when UseFramePointer
+  // is false, the offsets depend on the gap between SpillAreaSizeBytes
+  // and SpillAreaPaddingBytes, so we don't increment that.
+  size_t TestPadding = Ctx->getFlags().getTestStackExtra();
+  if (TestPadding && UsesFramePointer)

[Jim Stichnoth, 2015/07/24 22:08:29]

Maybe just remove "TestPadding && " ?

[jvoung (off chromium), 2015/07/27 17:02:57]

Done.

+    SpillAreaPaddingBytes += TestPadding;
   size_t GlobalsSpaceUsed = SpillAreaPaddingBytes;
   size_t NextStackOffset = SpillAreaPaddingBytes;
   std::vector<size_t> LocalsSize(Func->getNumNodes());
   const bool SimpleCoalescing = !callsReturnsTwice();
+
   for (Variable *Var : SortedSpilledVariables) {
     size_t Increment = typeWidthInBytesOnStack(Var->getType());
     if (SimpleCoalescing && VMetadata->isTracked(Var)) {