Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1241723005: Add Rec709 YUV color space support to GrYUVtoRGBEffect. (Closed)

Created:
5 years, 5 months ago by rileya (GONE FROM CHROMIUM)
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add Rec709 YUV color space support to GrYUVtoRGBEffect. This change is motivated by a recent switch in how chromium handles <video> color spaces, making rec709 more commonly used. This will allow video -> canvas copies to take the fast GPU path when we're using 709, just as we do with 601 and jpeg. Chromium-side change: https://codereview.chromium.org/1236313002 Committed: https://skia.googlesource.com/skia/+/134003902de13ade7795c5145a59b1e77770f2de

Patch Set 1 #

Patch Set 2 : Tricksy floatses. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M gm/yuvtorgbeffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkImageInfo.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 1 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
rileya (GONE FROM CHROMIUM)
5 years, 5 months ago (2015-07-16 18:25:39 UTC) #2
reed1
lgtm
5 years, 5 months ago (2015-07-16 18:28:14 UTC) #4
bsalomon
lgtm
5 years, 5 months ago (2015-07-16 18:31:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241723005/1
5 years, 5 months ago (2015-07-20 17:27:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/2115) Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 5 months ago (2015-07-20 17:31:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241723005/20001
5 years, 5 months ago (2015-07-20 21:49:09 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/2172)
5 years, 5 months ago (2015-07-20 21:52:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241723005/20001
5 years, 5 months ago (2015-07-20 21:56:27 UTC) #17
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 22:00:07 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/134003902de13ade7795c5145a59b1e77770f2de

Powered by Google App Engine
This is Rietveld 408576698