Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1241713004: In RegExp, lastIndex is read with ToLength, not ToInteger (Closed)

Created:
5 years, 5 months ago by Dan Ehrenberg
Modified:
5 years, 5 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

In RegExp, lastIndex is read with ToLength, not ToInteger ES2015 made a change vs ES5, where the "lastIndex" property of a RegExp (which can be modified by a user to start the next search at a different location) is cast to an integer with ToLength rather than ToInteger. The main difference is on negative numbers, and this is tested by test262. This patch implements that change on RegExps and enables the test262 test now that it passes. R=adamk LOG=Y BUG=v8:4244 Committed: https://crrev.com/1f61ac50338cc2ef1a54735206351f9798687248 Cr-Commit-Position: refs/heads/master@{#29715}

Patch Set 1 #

Patch Set 2 : Disable invalid Mozilla test #

Patch Set 3 : mark outdated test262 #

Patch Set 4 : Fix name of obsolete test262 test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M src/regexp.js View 2 chunks +6 lines, -6 lines 0 comments Download
M test/mozilla/mozilla.status View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/test262-es6/test262-es6.status View 1 chunk +0 lines, -3 lines 0 comments Download
M test/test262/test262.status View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
Dan Ehrenberg
5 years, 5 months ago (2015-07-15 00:28:57 UTC) #1
adamk
It looks to me like the test262 only exercises one of these code paths, though ...
5 years, 5 months ago (2015-07-15 00:35:52 UTC) #2
Dan Ehrenberg
On 2015/07/15 00:35:52, adamk wrote: > It looks to me like the test262 only exercises ...
5 years, 5 months ago (2015-07-15 02:48:09 UTC) #3
adamk
lgtm
5 years, 5 months ago (2015-07-15 15:07:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241713004/1
5 years, 5 months ago (2015-07-16 00:31:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/7662)
5 years, 5 months ago (2015-07-16 01:12:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241713004/20001
5 years, 5 months ago (2015-07-16 18:46:02 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/7704)
5 years, 5 months ago (2015-07-16 19:30:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241713004/40001
5 years, 5 months ago (2015-07-16 20:18:45 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/7709)
5 years, 5 months ago (2015-07-16 21:04:59 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241713004/60001
5 years, 5 months ago (2015-07-16 21:14:45 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-07-16 21:55:36 UTC) #22
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 21:55:53 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1f61ac50338cc2ef1a54735206351f9798687248
Cr-Commit-Position: refs/heads/master@{#29715}

Powered by Google App Engine
This is Rietveld 408576698