LayoutTests/fast/multicol/negative-margins-crash-expected.txt - Issue 1241703005: Make sure that no column rows get negative flow thread portion heights.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/negative-margins-crash-expected.txt

Issue 1241703005: Make sure that no column rows get negative flow thread portion heights. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 PASS if no crash or assertion failure.	1 PASS if no crash or assertion failure.
	dsinclair 2015/07/15 13:51:59 Out of curiosity, could this be turned into a ref Out of curiosity, could this be turned into a ref test? We get the benefit of the crash, and we know it still works correctly in the future. (I ran into a bunch of CRASH tests that would fail during repaint-after-layout and it was hard to figure out what they were suppose to look like) mstensho (USE GERRIT) 2015/07/15 16:26:44 Our overflow handling in multicol is pretty lousy, Show quoted text On 2015/07/15 13:51:59, dsinclair wrote: > Out of curiosity, could this be turned into a ref test? We get the benefit of > the crash, and we know it still works correctly in the future. > > (I ran into a bunch of CRASH tests that would fail during repaint-after-layout > and it was hard to figure out what they were suppose to look like) Our overflow handling in multicol is pretty lousy, so this won't paint as expected. All I was after with this patch, was to get rid of the assertion failure and not confuse the multicol layout code. Kind of sucky, I know.
2	2

3	3

4	4

OLD	NEW