Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1241703005: Make sure that no column rows get negative flow thread portion heights. (Closed)

Created:
5 years, 5 months ago by mstensho (USE GERRIT)
Modified:
5 years, 5 months ago
Reviewers:
dsinclair
CC:
blink-reviews, szager+layoutwatch_chromium.org, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering, mstensho (USE GERRIT)
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Make sure that no column rows get negative flow thread portion heights. BUG=510390 R=dsinclair@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198970

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
A LayoutTests/fast/multicol/negative-margins-crash.html View 1 chunk +12 lines, -0 lines 0 comments Download
A + LayoutTests/fast/multicol/negative-margins-crash-expected.txt View 0 chunks +-1 lines, --1 lines 2 comments Download
M Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M Source/core/layout/MultiColumnFragmentainerGroup.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
mstensho (USE GERRIT)
5 years, 5 months ago (2015-07-15 11:17:40 UTC) #1
dsinclair
https://codereview.chromium.org/1241703005/diff/1/LayoutTests/fast/multicol/negative-margins-crash-expected.txt File LayoutTests/fast/multicol/negative-margins-crash-expected.txt (right): https://codereview.chromium.org/1241703005/diff/1/LayoutTests/fast/multicol/negative-margins-crash-expected.txt#newcode1 LayoutTests/fast/multicol/negative-margins-crash-expected.txt:1: PASS if no crash or assertion failure. Out of ...
5 years, 5 months ago (2015-07-15 13:51:59 UTC) #2
mstensho (USE GERRIT)
https://codereview.chromium.org/1241703005/diff/1/LayoutTests/fast/multicol/negative-margins-crash-expected.txt File LayoutTests/fast/multicol/negative-margins-crash-expected.txt (right): https://codereview.chromium.org/1241703005/diff/1/LayoutTests/fast/multicol/negative-margins-crash-expected.txt#newcode1 LayoutTests/fast/multicol/negative-margins-crash-expected.txt:1: PASS if no crash or assertion failure. On 2015/07/15 ...
5 years, 5 months ago (2015-07-15 16:26:44 UTC) #3
dsinclair
lgtm
5 years, 5 months ago (2015-07-15 17:47:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241703005/1
5 years, 5 months ago (2015-07-15 17:48:28 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 17:52:13 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198970

Powered by Google App Engine
This is Rietveld 408576698