Issue 1241703003: Use AnimationVariables to drive PopupMenu animation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1241703003: Use AnimationVariables to drive PopupMenu animation (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
mpcomplete, Matt Perry

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -21 lines)			Patch
	M	sky/sdk/lib/animation/animation_performance.dart	View	1 2	1 chunk	+21 lines, -3 lines	0 comments	Download
	M	sky/sdk/lib/widgets/popup_menu.dart	View		4 chunks	+32 lines, -18 lines	0 comments	Download

Total messages: 4 (1 generated)

Matt Perry

cool, lgtm Now I just need to figure out how to make it less verbose.

5 years, 5 months ago (2015-07-14 19:35:02 UTC) #3

abarth-chromium

5 years, 5 months ago (2015-07-14 20:10:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
b937de50dc6fcdfc49d2cf4c96e95f40e901380a (presubmit successful).