Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1241703003: Use AnimationVariables to drive PopupMenu animation (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
mpcomplete, Matt Perry
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rm debug #

Patch Set 3 : adjustedTime moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -21 lines) Patch
M sky/sdk/lib/animation/animation_performance.dart View 1 2 1 chunk +21 lines, -3 lines 0 comments Download
M sky/sdk/lib/widgets/popup_menu.dart View 4 chunks +32 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 5 months ago (2015-07-14 19:31:13 UTC) #1
Matt Perry
cool, lgtm Now I just need to figure out how to make it less verbose.
5 years, 5 months ago (2015-07-14 19:35:02 UTC) #3
abarth-chromium
5 years, 5 months ago (2015-07-14 20:10:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
b937de50dc6fcdfc49d2cf4c96e95f40e901380a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698