Update the test runner to use the new dart:io API

tools/test.dart

 #!/usr/bin/env dart
-// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * This file is the entrypoint of the dart test suite.  This suite is used
  * to test:
  *
  *     1. the dart vm
  *     2. the dart2js compiler
  *     3. the dartc static analyzer
@@ skipping 51 matching lines @@
     new Path('tests/lib'),
     new Path('tests/standalone'),
     new Path('tests/utils'),
     new Path('utils/tests/css'),
     new Path('utils/tests/peg'),
     new Path('utils/tests/pub'),
     new Path('sdk/lib/_internal/dartdoc'),
 ];
 
 main() {
-  var startTime = new Date.now();
+  var startTime = new DateTime.now();
   var optionsParser = new TestOptionsParser();
   List<Map> configurations = optionsParser.parse(new Options().arguments);
   if (configurations == null || configurations.length == 0) return;
 
   // Extract global options from first configuration.
   var firstConf = configurations[0];
   Map<String, RegExp> selectors = firstConf['selectors'];
   var maxProcesses = firstConf['tasks'];
   var progressIndicator = firstConf['progress'];
   BuildbotProgressIndicator.stepName = firstConf['step_name'];
@@ skipping 13 matching lines @@
       TestUtils.debugLogfile() : null, append: firstConf['append_logs']);
 
   // Print the configurations being run by this execution of
   // test.dart. However, don't do it if the silent progress indicator
   // is used. This is only needed because of the junit tests.
   if (progressIndicator != 'silent') {
     List output_words = configurations.length > 1 ?
         ['Test configurations:'] : ['Test configuration:'];
     for (Map conf in configurations) {
       List settings = ['compiler', 'runtime', 'mode', 'arch']
-          .mappedBy((name) => conf[name]).toList();
+          .map((name) => conf[name]).toList();
       if (conf['checked']) settings.add('checked');
       output_words.add(settings.join('_'));
     }
     print(output_words.join(' '));
   }
 
   var runningBrowserTests = configurations.any((config) {
     return TestUtils.isBrowserRuntime(config['runtime']);
   });
 
+  List<TestingServers> servers = [];

[ricow1, 2013/03/13 13:38:41]

how do we make sure that these are shut down?

[Søren Gjesse, 2013/03/13 15:17:18]

It is handled in allTestsFinished().

   var testSuites = new List<TestSuite>();
   var maxBrowserProcesses = maxProcesses;
   for (var conf in configurations) {
     if (!listTests && runningBrowserTests) {
       // Start global http servers that serve the entire dart repo.
       // The http server is available on window.location.port, and a second
       // server for cross-domain tests can be found by calling
       // getCrossOriginPortNumber().
-      var servers = new TestingServers(new Path(TestUtils.buildDir(conf)),
-                                       useContentSecurityPolicy);
-      servers.startServers('127.0.0.1');
-      conf['_servers_'] = servers;
+      servers.add(new TestingServers(new Path(TestUtils.buildDir(conf)),
+                                     useContentSecurityPolicy));
+      conf['_servers_'] = servers.last;
     }
 
     // There should not be more than one InternetExplorerDriver instance
     // running at a time. For details, see
     // http://code.google.com/p/selenium/wiki/InternetExplorerDriver.
     if (conf['runtime'].startsWith('ie')) {
       maxBrowserProcesses = 1;
     }
 
     for (String key in selectors.keys) {
@@ skipping 55 matching lines @@
                                                      startTime,
                                                      formatter));
     if (printTiming) {
       eventListener.add(new TimingPrinter(startTime));
     }
     eventListener.add(new SkippedCompilationsPrinter());
     eventListener.add(new LeftOverTempDirPrinter());
   }
   eventListener.add(new ExitCodeSetter());
 
-  // Start process queue.
-  new ProcessQueue(maxProcesses,
-                   maxBrowserProcesses,
-                   startTime,
-                   testSuites,
-                   eventListener,
-                   allTestsFinished,
-                   verbose,
-                   listTests);
+  void startProcessQueue() {
+    // Start process queue.
+    new ProcessQueue(maxProcesses,
+                     maxBrowserProcesses,
+                     startTime,
+                     testSuites,
+                     eventListener,
+                     allTestsFinished,
+                     verbose,
+                     listTests);
+  }
+
+  void startTesting(List<TestingServers> servers) {
+    // Start all the HTTP servers required before starting the process queue.
+    if (servers.isEmpty) {
+      startProcessQueue();
+    } else {
+      TestingServers server = servers.removeLast();
+      server.startServers('127.0.0.1').then((_) {

[Bill Hesse, 2013/03/13 12:56:41]

Could this take long enough that we would prefer to start them in parallel, and
use Future.wait?

[Søren Gjesse, 2013/03/13 15:17:18]

Changed to what kustermann@ suggested.

+        startTesting(servers);
+      });
+    }
+  }
+
+  startTesting(servers);
 }