Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 1241693003: Revert "Enable checks for outdated plugins even when third-party plugin installation is not enabled" (Closed)

Created:
5 years, 5 months ago by Bernhard Bauer
Modified:
5 years, 5 months ago
Reviewers:
Will Harris
CC:
chromium-reviews, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable checks for outdated plugins even when third-party plugin installation is not enabled. (patchset #1 id:1 of https://codereview.chromium.org/1234223003/) Reason for revert: Crashes when encountering an outdated plugin on Linux/CrOS (https://crbug.com/510684 and https://crbug.com/510567). Original issue's description: > Enable checks for outdated plugins even when third-party plugin installation is not enabled. > > Even built-in plugins can be outdated, in particular if plugin metadata is updated separately from a Chrome update. > > BUG=509832 > > Committed: https://crrev.com/364aa7f794daadbe497a0ad02621aa1d5a400a49 > Cr-Commit-Position: refs/heads/master@{#338869} TBR=wfh@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=509832 Committed: https://crrev.com/fa9dc9ac45aeb564acf426b626e6398822f76a4b Cr-Commit-Position: refs/heads/master@{#339005}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/plugins/plugin_info_message_filter.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bernhard Bauer
Created Revert of Enable checks for outdated plugins even when third-party plugin installation is not ...
5 years, 5 months ago (2015-07-16 09:10:04 UTC) #1
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-16 09:10:59 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 09:11:50 UTC) #3
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa9dc9ac45aeb564acf426b626e6398822f76a4b
Cr-Commit-Position: refs/heads/master@{#339005}

Powered by Google App Engine
This is Rietveld 408576698