Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1241673004: Minor sky/engine updates for Mac target (Closed)

Created:
5 years, 5 months ago by Chinmay
Modified:
5 years, 5 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove file added as a result of a bad merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -104 lines) Patch
M sky/engine/core/editing/EditingBehavior.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M sky/engine/core/painting/CanvasImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/script/dart_debugger.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/script/monitor.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/BUILD.gn View 1 3 chunks +4 lines, -5 lines 0 comments Download
A + sky/engine/platform/fonts/apple/FontPlatformDataApple.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
M sky/engine/platform/fonts/harfbuzz/FontHarfBuzz.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
D sky/engine/platform/fonts/ios/FontPlatformDataIOS.cpp View 1 chunk +0 lines, -82 lines 0 comments Download
M sky/engine/platform/fonts/skia/FontCacheSkia.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/platform/fonts/skia/SimpleFontDataSkia.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Chinmay
5 years, 5 months ago (2015-07-15 20:56:00 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/1241673004/diff/1/sky/engine/platform/BUILD.gn File sky/engine/platform/BUILD.gn (right): https://codereview.chromium.org/1241673004/diff/1/sky/engine/platform/BUILD.gn#newcode621 sky/engine/platform/BUILD.gn:621: "network/HTTPParsersTest.cpp", Bad merge? This file should have been ...
5 years, 5 months ago (2015-07-15 20:57:41 UTC) #3
Chinmay
https://codereview.chromium.org/1241673004/diff/1/sky/engine/platform/BUILD.gn File sky/engine/platform/BUILD.gn (right): https://codereview.chromium.org/1241673004/diff/1/sky/engine/platform/BUILD.gn#newcode621 sky/engine/platform/BUILD.gn:621: "network/HTTPParsersTest.cpp", On 2015/07/15 at 20:57:40, abarth-chromium wrote: > Bad ...
5 years, 5 months ago (2015-07-15 21:05:56 UTC) #4
Chinmay
https://codereview.chromium.org/1241673004/diff/1/sky/engine/platform/BUILD.gn File sky/engine/platform/BUILD.gn (right): https://codereview.chromium.org/1241673004/diff/1/sky/engine/platform/BUILD.gn#newcode621 sky/engine/platform/BUILD.gn:621: "network/HTTPParsersTest.cpp", On 2015/07/15 at 20:57:40, abarth-chromium wrote: > Bad ...
5 years, 5 months ago (2015-07-15 21:05:56 UTC) #5
Chinmay
5 years, 5 months ago (2015-07-15 21:12:18 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
087b1afcaca2d6623fcc2b25b55ae486d3ee7728 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698