Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 1241613006: Reland "Change fallback font collection in HarfBuzzShaper" (Closed)

Created:
5 years, 5 months ago by eae
Modified:
5 years, 5 months ago
CC:
blink-reviews, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reland "Change fallback font collection in HarfBuzzShaper" Change HarfBuzzShaper to not populate the fallback font list during text shaping and instead populate it based on the ShapeResult objects at call time. This circumvents additional registration work and renders the text shaping API simpler and more consistent. Originally landed in r198813 (bbb929c88fbe43979dbb9b2b20218538) and then reverted in r198818 (64e30826c261ac7a2607e891dbe7e9d2d251e5f3) by virtue of Mac 10.6 test failures caused by a missing NULL check, since added. This is a speculative fix. R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198886

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -58 lines) Patch
M Source/platform/fonts/Font.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/platform/fonts/shaping/CachingWordShapeIterator.h View 6 chunks +9 lines, -28 lines 0 comments Download
M Source/platform/fonts/shaping/CachingWordShaper.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M Source/platform/fonts/shaping/CachingWordShaperTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/shaping/HarfBuzzShaper.h View 3 chunks +3 lines, -7 lines 0 comments Download
M Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 4 chunks +11 lines, -9 lines 0 comments Download
M Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp View 8 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
eae
5 years, 5 months ago (2015-07-14 18:54:09 UTC) #2
leviw_travelin_and_unemployed
Can you change the description to mention that this is a speculative fix? LGTM.
5 years, 5 months ago (2015-07-14 19:36:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241613006/1
5 years, 5 months ago (2015-07-14 20:00:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=198886
5 years, 5 months ago (2015-07-14 20:04:03 UTC) #6
Noel Gordon
5 years, 5 months ago (2015-07-15 04:36:34 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1235163007/ by noel@chromium.org.

The reason for reverting is: Broke Linux MSAN bots.

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/bu...

See stdio log of 4412 build: many reports use on an uninitialized variable in
shaping font fallback, about 100+ tests failing that way..

Powered by Google App Engine
This is Rietveld 408576698