Source/modules/serviceworkers/ServiceWorkerGlobalScope.h - Issue 1241613004: Rework dispatchEvent so it is consistent for isTrusted support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

Issue 1241613004: Rework dispatchEvent so it is consistent for isTrusted support. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Work around MSVC optimization bug Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/workers/WorkerEventQueue.cpp ('K') | « Source/modules/notifications/Notification.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

index 323034eef93ae6dc24064aed3813e758c6664723..8f5d3549c5d8a72c7c44cecd1309386e69f5818f 100644

--- a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

+++ b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

@@ -81,7 +81,6 @@ public:

// EventTarget

bool addEventListener(const AtomicString& eventType, PassRefPtr<EventListener>, bool useCapture = false) override;

const AtomicString& interfaceName() const override;

- bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) override;

void dispatchExtendableEvent(PassRefPtrWillBeRawPtr<Event>, WaitUntilObserver*);

@@ -93,6 +92,10 @@ public:

DECLARE_VIRTUAL_TRACE();

+protected:

+ // EventTarget

+ bool dispatchEventInternal(PassRefPtrWillBeRawPtr<Event>) override;

private:

class SkipWaitingCallback;