Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Unified Diff: Source/modules/indexeddb/IDBDatabase.h

Issue 1241613004: Rework dispatchEvent so it is consistent for isTrusted support. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/indexeddb/IDBDatabase.h
diff --git a/Source/modules/indexeddb/IDBDatabase.h b/Source/modules/indexeddb/IDBDatabase.h
index 31f5d2de4618ef5e556273734bddc0f6b27c8625..06480e3f519bbcbcc26cb9ead0fd90152b546d10 100644
--- a/Source/modules/indexeddb/IDBDatabase.h
+++ b/Source/modules/indexeddb/IDBDatabase.h
@@ -102,9 +102,6 @@ public:
const IDBDatabaseMetadata& metadata() const { return m_metadata; }
void enqueueEvent(PassRefPtrWillBeRawPtr<Event>);
- using EventTarget::dispatchEvent;
- bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) override;
-
int64_t findObjectStoreId(const String& name) const;
bool containsObjectStore(const String& name) const
{
@@ -133,6 +130,9 @@ public:
static const char databaseClosedErrorMessage[];
static const char notValidMaxCountErrorMessage[];
+protected:
+ bool dispatchEventInternal(PassRefPtrWillBeRawPtr<Event>) override;
tkent 2015/07/15 00:00:54 I recommend to add a comment indicating what this
dtapuska 2015/07/15 22:34:42 Done.
+
private:
IDBDatabase(ExecutionContext*, PassOwnPtr<WebIDBDatabase>, IDBDatabaseCallbacks*);

Powered by Google App Engine
This is Rietveld 408576698