Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Side by Side Diff: Source/core/html/track/TextTrackCue.cpp

Issue 1241613004: Rework dispatchEvent so it is consistent for isTrusted support. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Work around MSVC optimization bug Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2011, 2012, 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2011, 2012, 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 { 130 {
131 // This method can only be called on cues while they are associated with 131 // This method can only be called on cues while they are associated with
132 // a(n enabled) track (and hence that track's list of cues should exist.) 132 // a(n enabled) track (and hence that track's list of cues should exist.)
133 ASSERT(track() && track()->cues()); 133 ASSERT(track() && track()->cues());
134 TextTrackCueList* cueList = track()->cues(); 134 TextTrackCueList* cueList = track()->cues();
135 if (!cueList->isCueIndexValid(m_cueIndex)) 135 if (!cueList->isCueIndexValid(m_cueIndex))
136 cueList->validateCueIndexes(); 136 cueList->validateCueIndexes();
137 return m_cueIndex; 137 return m_cueIndex;
138 } 138 }
139 139
140 bool TextTrackCue::dispatchEvent(PassRefPtrWillBeRawPtr<Event> event) 140 bool TextTrackCue::dispatchEventInternal(PassRefPtrWillBeRawPtr<Event> event)
141 { 141 {
142 // When a TextTrack's mode is disabled: no cues are active, no events fired. 142 // When a TextTrack's mode is disabled: no cues are active, no events fired.
143 if (!track() || track()->mode() == TextTrack::disabledKeyword()) 143 if (!track() || track()->mode() == TextTrack::disabledKeyword())
144 return false; 144 return false;
145 145
146 return EventTarget::dispatchEvent(event); 146 return EventTarget::dispatchEventInternal(event);
147 } 147 }
148 148
149 const AtomicString& TextTrackCue::interfaceName() const 149 const AtomicString& TextTrackCue::interfaceName() const
150 { 150 {
151 return EventTargetNames::TextTrackCue; 151 return EventTargetNames::TextTrackCue;
152 } 152 }
153 153
154 DEFINE_TRACE(TextTrackCue) 154 DEFINE_TRACE(TextTrackCue)
155 { 155 {
156 visitor->trace(m_track); 156 visitor->trace(m_track);
157 EventTargetWithInlineData::trace(visitor); 157 EventTargetWithInlineData::trace(visitor);
158 } 158 }
159 159
160 } // namespace blink 160 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698