Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1241583007: Reland of Add fast normalize for SkLightingImageFilter. (Closed)

Created:
5 years, 5 months ago by jvanverth1
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reland of Add fast normalize for SkLightingImageFilter. (patchset #1 id:1 of https://codereview.chromium.org/1244523002/) Reason for revert: Florin will rebaseline the images. Original issue's description: > Revert of Add fast normalize for SkLightingImageFilter. (patchset #2 id:20001 of https://codereview.chromium.org/1240023002/) > > Reason for revert: > Speculative revert -- DEPS roll block on linux_blink_rel > > https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/71483/layout-test-results/results.html > > Original issue's description: > > Add fast normalize for SkLightingImageFilter. > > > > The normalize routine in SkPoint3 is very robust. However, for simple > > lighting cases we prefer speed over robustness. This fixes a perf > > regression in smoothness.tough_filters_cases. > > > > BUG=chromium:510562 > > > > Committed: https://skia.googlesource.com/skia/+/dfa0ecf169db87f7afddd93bc1c500de481a62c7 > > TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org,jvanverth@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:510562 > > Committed: https://skia.googlesource.com/skia/+/ac66a8122b27c388cc74b3913d9a9be351a44e54 TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org,reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:510562 Committed: https://skia.googlesource.com/skia/+/992c7612394a26e36ba355f6d8d3801d8d8f1260

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M src/effects/SkLightingImageFilter.cpp View 7 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jvanverth1
Created Reland of Add fast normalize for SkLightingImageFilter.
5 years, 5 months ago (2015-07-17 14:22:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241583007/1
5 years, 5 months ago (2015-07-17 14:22:28 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 14:22:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/992c7612394a26e36ba355f6d8d3801d8d8f1260

Powered by Google App Engine
This is Rietveld 408576698