Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1241583003: Remove all remaining HashMap and HashSet usages except dart_string_cache (Closed)

Created:
5 years, 5 months ago by Cutch
Modified:
5 years, 5 months ago
Reviewers:
abarth, abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove all remaining HashMap and HashSet usages except dart_string_cache BUG= R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/282d60e3899fd41adea63253d702e67a3b531cf5

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -36 lines) Patch
M sky/engine/tonic/dart_dependency_catcher.h View 2 chunks +6 lines, -3 lines 0 comments Download
M sky/engine/tonic/dart_dependency_catcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/tonic/dart_library_loader.h View 3 chunks +7 lines, -5 lines 0 comments Download
M sky/engine/tonic/dart_library_loader.cc View 1 8 chunks +33 lines, -21 lines 0 comments Download
M sky/engine/tonic/dart_timer_heap.h View 2 chunks +3 lines, -2 lines 0 comments Download
M sky/engine/tonic/dart_timer_heap.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Cutch
5 years, 5 months ago (2015-07-16 16:44:44 UTC) #2
abarth-chromium
LGTM https://codereview.chromium.org/1241583003/diff/1/sky/engine/tonic/dart_library_loader.cc File sky/engine/tonic/dart_library_loader.cc (right): https://codereview.chromium.org/1241583003/diff/1/sky/engine/tonic/dart_library_loader.cc#newcode29 sky/engine/tonic/dart_library_loader.cc:29: } Please wrap this function in an anonymous ...
5 years, 5 months ago (2015-07-16 16:50:42 UTC) #4
Cutch
https://codereview.chromium.org/1241583003/diff/1/sky/engine/tonic/dart_library_loader.cc File sky/engine/tonic/dart_library_loader.cc (right): https://codereview.chromium.org/1241583003/diff/1/sky/engine/tonic/dart_library_loader.cc#newcode29 sky/engine/tonic/dart_library_loader.cc:29: } On 2015/07/16 16:50:42, abarth-chromium wrote: > Please wrap ...
5 years, 5 months ago (2015-07-16 17:00:51 UTC) #5
Cutch
5 years, 5 months ago (2015-07-16 17:01:07 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
282d60e3899fd41adea63253d702e67a3b531cf5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698