Update implementation following changes to URLRequest cache mode.

Update implementation following changes to URLRequest cache mode.

R=viettrungluu@chromium.org

Committed: https://github.com/domokit/monetf4116cee892c698374ee7ae9ad8e6cea69741122

[viettrungluu, 2015-07-20 17:00:28]

lgtm assuming handling invalid enum values is just "delete this; return;".

https://codereview.chromium.org/1241553003/diff/1/mojo/services/network/url_l...
File mojo/services/network/url_loader_impl.cc (right):

https://codereview.chromium.org/1241553003/diff/1/mojo/services/network/url_l...
mojo/services/network/url_loader_impl.cc:548: }
Since we don't validate enums, you should have a default case (which presumably
treats it as an error, probably by deleting this, I think).

[qsr, 2015-07-20 18:30:50]

https://codereview.chromium.org/1241553003/diff/1/mojo/services/network/url_l...
File mojo/services/network/url_loader_impl.cc (right):

https://codereview.chromium.org/1241553003/diff/1/mojo/services/network/url_l...
mojo/services/network/url_loader_impl.cc:548: }
On 2015/07/20 17:00:28, viettrungluu wrote:
> Since we don't validate enums, you should have a default case (which
presumably
> treats it as an error, probably by deleting this, I think).

Hum... I'm kind of torn here. If I don't do this, I will get an error when
trying to update the network service.

Would you mind:
load_flags = -1;
swicth() {
...
}
if (load_flags == -1) { delete this; }
?

[viettrungluu, 2015-07-20 21:54:17]

On 2015/07/20 18:30:50, qsr wrote:
>
https://codereview.chromium.org/1241553003/diff/1/mojo/services/network/url_l...
> File mojo/services/network/url_loader_impl.cc (right):
> 
>
https://codereview.chromium.org/1241553003/diff/1/mojo/services/network/url_l...
> mojo/services/network/url_loader_impl.cc:548: }
> On 2015/07/20 17:00:28, viettrungluu wrote:
> > Since we don't validate enums, you should have a default case (which
> presumably
> > treats it as an error, probably by deleting this, I think).
> 
> Hum... I'm kind of torn here. If I don't do this, I will get an error when
> trying to update the network service.
> 
> Would you mind:
> load_flags = -1;
> swicth() {
> ...
> }
> if (load_flags == -1) { delete this; }
> ?

It's not obvious to me what the problem is, but can you do it as a sequence of
changes instead? (E.g., commit this change without validation, do the update,
add in the check, etc.)

[qsr, 2015-07-20 22:15:05]

Committed patchset #2 (id:20001) manually as
f4116cee892c698374ee7ae9ad8e6cea69741122 (presubmit successful).