Issue 1241493002: Merge to M44: Integer overflow in CJBig2_Image::expand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1241493002: Merge to M44: Integer overflow in CJBig2_Image::expand (Closed)

Created:
5 years, 5 months ago by Lei Zhang

Modified:
5 years, 5 months ago

Reviewers:
Tom Sepez, brucedawson

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@2403

Target Ref:
refs/heads/chromium/2403

Visibility:
Public.

Merge to M44: Integer overflow in CJBig2_Image::expand 1. New size should be larger than old size in JBig2_Realloc. 2. Arguments are integers but parameters are size_t in JBIG2_memset. After integer overflows, it will be presented as a huge unsigned number on 64 bits system. BUG=483981 R=brucedawson@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/1148643002 (cherry picked from commit e9ccc9bc449846107f1c539e25677f4877ddf22f) Committed: https://pdfium.googlesource.com/pdfium/+/12d0f7b4eae9c2b40433500b15955f61050132aa

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -6 lines)			Patch
	M	core/src/fxcodec/jbig2/JBig2_Image.cpp	View		1 chunk	+13 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

Lei Zhang

Committed patchset #1 (id:1) manually as 12d0f7b4eae9c2b40433500b15955f61050132aa (presubmit successful).

5 years, 5 months ago (2015-07-13 23:47:41 UTC) #2

Message was sent while issue was closed.

lgtm