Issue 1241483002: Improve drawer menu items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1241483002: Improve drawer menu items (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Improve drawer menu items - Use a separate selected and highlight color (now part of ThemeData) - Colorize the icon of the selected menu item R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/b9748cf0072ab1dfae7d5313d213530c65989432

Patch Set 1 #

Total comments: 2

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -34 lines)			Patch
M	sky/sdk/example/demo_launcher/lib/main.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/example/widgets/card_collection.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/theme/colors.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/theme/theme_data.dart	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	sky/sdk/lib/widgets/dialog.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/widgets/menu_item.dart	View	5 chunks	+31 lines, -26 lines	2 comments	Download
M	sky/sdk/lib/widgets/tabs.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hixie

lgtm https://codereview.chromium.org/1241483002/diff/1/sky/sdk/lib/widgets/menu_item.dart File sky/sdk/lib/widgets/menu_item.dart (right): https://codereview.chromium.org/1241483002/diff/1/sky/sdk/lib/widgets/menu_item.dart#newcode34 sky/sdk/lib/widgets/menu_item.dart:34: TextStyle _textStyle(ThemeData themeData) { name it using a ...

5 years, 5 months ago (2015-07-13 23:48:22 UTC) #2

abarth-chromium

5 years, 5 months ago (2015-07-13 23:50:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b9748cf0072ab1dfae7d5313d213530c65989432 (presubmit successful).

Expand Messages | Collapse Messages