Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1241463003: Stop propagating text decorations on outermost SVG roots (Closed)

Created:
5 years, 5 months ago by fs
Modified:
5 years, 5 months ago
Reviewers:
pdr.
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Stop propagating text decorations on outermost SVG roots Outermost SVG roots should be consider atomic inline-level, and hence text decorations should not propagate into them from the outside. BUG=406966 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199132

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
A LayoutTests/svg/text/text-decoration-propagation.html View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/text-decoration-propagation-2.html View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/text-decoration-propagation-2-expected.html View 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/svg/text/text-decoration-propagation-expected.html View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
fs
5 years, 5 months ago (2015-07-15 18:31:14 UTC) #2
Timothy Loh
FYI LayoutObject::getTextDecorations has some logic which may or may not need to be updated, but ...
5 years, 5 months ago (2015-07-17 01:03:02 UTC) #3
fs
On 2015/07/17 01:03:02, Timothy Loh wrote: > FYI LayoutObject::getTextDecorations has some logic which may or ...
5 years, 5 months ago (2015-07-17 07:42:30 UTC) #4
pdr.
lgtm
5 years, 5 months ago (2015-07-17 17:51:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241463003/1
5 years, 5 months ago (2015-07-17 17:52:35 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 19:52:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199132

Powered by Google App Engine
This is Rietveld 408576698