Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issue 1241443002: Reduce the quality of the blur in the material shadows (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Reduce the quality of the blur in the material shadows Using a high-quality blur takes a long time in Skia, and it's hard/impossible to see the difference visually. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/55f29ac8b0b56abe5b4a37a8ba88253dc21971af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M sky/sdk/lib/painting/shadows.dart View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 5 months ago (2015-07-13 19:48:44 UTC) #1
Hixie
lgtm the quality will decrease until performance improves!
5 years, 5 months ago (2015-07-13 19:49:37 UTC) #2
abarth-chromium
5 years, 5 months ago (2015-07-13 19:50:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
55f29ac8b0b56abe5b4a37a8ba88253dc21971af (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698