Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/isolate.gypi

Issue 124143002: Include icu.isolate instead of listing icudt.dll (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use # for comment Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/gtest/setup.py ('k') | chrome/chrome.isolate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/isolate.gypi
diff --git a/build/isolate.gypi b/build/isolate.gypi
index 0f2a301539206e1671bcca5366fdd9e8156107b0..cecf9b2551b932c5a01f1ee85596790c952b09b5 100644
--- a/build/isolate.gypi
+++ b/build/isolate.gypi
@@ -68,12 +68,15 @@
'<(test_isolation_mode)',
# Variables should use the -V FOO=<(FOO) form so frequent values,
# like '0' or '1', aren't stripped out by GYP.
+ # This list needs to be kept in sync with the cmd line options
+ # in src/build/android/pylib/gtest/setup.py.
'--path-variable', 'PRODUCT_DIR', '<(PRODUCT_DIR) ',
'--config-variable', 'OS=<(OS)',
# TODO(kbr): move this to chrome_tests.gypi:gles2_conform_tests_run
# once support for user-defined config variables is added.
'--config-variable',
'internal_gles2_conform_tests=<(internal_gles2_conform_tests)',
+ '--config-variable', 'icu_use_data_file_flag=<(icu_use_data_file_flag)',
'--result', '<@(_outputs)',
'--isolate', '<(RULE_INPUT_PATH)',
],
« no previous file with comments | « build/android/pylib/gtest/setup.py ('k') | chrome/chrome.isolate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698