 Chromium Code Reviews
 Chromium Code Reviews Issue 124143002:
  Include icu.isolate instead of listing icudt.dll  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 124143002:
  Include icu.isolate instead of listing icudt.dll  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW | 
|---|---|
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be | 
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. | 
| 4 | 4 | 
| 5 # This file is meant to be included into a target to provide a rule | 5 # This file is meant to be included into a target to provide a rule | 
| 6 # to "build" .isolate files into a .isolated file. | 6 # to "build" .isolate files into a .isolated file. | 
| 7 # | 7 # | 
| 8 # To use this, create a gyp target with the following form: | 8 # To use this, create a gyp target with the following form: | 
| 9 # 'conditions': [ | 9 # 'conditions': [ | 
| 10 # ['test_isolation_mode != "noop"', { | 10 # ['test_isolation_mode != "noop"', { | 
| (...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 60 #'<@(isolate_dependency_tracked)', | 60 #'<@(isolate_dependency_tracked)', | 
| 61 ], | 61 ], | 
| 62 'outputs': [ | 62 'outputs': [ | 
| 63 '<(PRODUCT_DIR)/<(RULE_INPUT_ROOT).isolated', | 63 '<(PRODUCT_DIR)/<(RULE_INPUT_ROOT).isolated', | 
| 64 ], | 64 ], | 
| 65 'action': [ | 65 'action': [ | 
| 66 'python', | 66 'python', | 
| 67 '<(DEPTH)/tools/swarming_client/isolate.py', | 67 '<(DEPTH)/tools/swarming_client/isolate.py', | 
| 68 '<(test_isolation_mode)', | 68 '<(test_isolation_mode)', | 
| 69 # Variables should use the -V FOO=<(FOO) form so frequent values, | 69 # Variables should use the -V FOO=<(FOO) form so frequent values, | 
| 70 # like '0' or '1', aren't stripped out by GYP. | 70 # like '0' or '1', aren't stripped out by GYP. | 
| 
M-A Ruel
2014/01/15 20:40:47
While at it, can you add a comment stating that th
 
jungshik at Google
2014/01/15 23:14:15
Done.
 | |
| 71 '--path-variable', 'PRODUCT_DIR', '<(PRODUCT_DIR) ', | 71 '--path-variable', 'PRODUCT_DIR', '<(PRODUCT_DIR) ', | 
| 72 '--config-variable', 'OS=<(OS)', | 72 '--config-variable', 'OS=<(OS)', | 
| 73 # TODO(kbr): move this to chrome_tests.gypi:gles2_conform_tests_run | 73 # TODO(kbr): move this to chrome_tests.gypi:gles2_conform_tests_run | 
| 74 # once support for user-defined config variables is added. | 74 # once support for user-defined config variables is added. | 
| 75 '--config-variable', | 75 '--config-variable', | 
| 76 'internal_gles2_conform_tests=<(internal_gles2_conform_tests)', | 76 'internal_gles2_conform_tests=<(internal_gles2_conform_tests)', | 
| 77 '--config-variable', 'icu_use_data_file_flag=<(icu_use_data_file_flag)', | |
| 77 '--result', '<@(_outputs)', | 78 '--result', '<@(_outputs)', | 
| 78 '--isolate', '<(RULE_INPUT_PATH)', | 79 '--isolate', '<(RULE_INPUT_PATH)', | 
| 79 ], | 80 ], | 
| 80 'conditions': [ | 81 'conditions': [ | 
| 81 # Note: When gyp merges lists, it appends them to the old value. | 82 # Note: When gyp merges lists, it appends them to the old value. | 
| 82 ['OS=="mac"', { | 83 ['OS=="mac"', { | 
| 83 # <(mac_product_name) can contain a space, so don't use FOO=<(FOO) | 84 # <(mac_product_name) can contain a space, so don't use FOO=<(FOO) | 
| 84 # form. | 85 # form. | 
| 85 'action': [ | 86 'action': [ | 
| 86 '--extra-variable', 'mac_product_name', '<(mac_product_name)', | 87 '--extra-variable', 'mac_product_name', '<(mac_product_name)', | 
| (...skipping 13 matching lines...) Expand all Loading... | |
| 100 ['test_isolation_fail_on_missing == 0', { | 101 ['test_isolation_fail_on_missing == 0', { | 
| 101 'action': ['--ignore_broken_items'], | 102 'action': ['--ignore_broken_items'], | 
| 102 }, | 103 }, | 
| 103 ], | 104 ], | 
| 104 ], | 105 ], | 
| 105 | 106 | 
| 106 'msvs_cygwin_shell': 0, | 107 'msvs_cygwin_shell': 0, | 
| 107 }, | 108 }, | 
| 108 ], | 109 ], | 
| 109 } | 110 } | 
| OLD | NEW |