Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 12414011: MIPS: To fully support hydrogen code stubs which accept a variable number of arguments, the HReturn… (Closed)

Created:
7 years, 9 months ago by palfia
Modified:
7 years, 9 months ago
Reviewers:
kisg, Paul Lind, mvstanton, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: To fully support hydrogen code stubs which accept a variable number of arguments, the HReturn/LReturn instruction needs to be able to determine argument count from a stack evaluation rather than as a constant from scope. Port r13888 (33905114) BUG= Committed: https://code.google.com/p/v8/source/detail?r=13910

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -7 lines) Patch
M src/mips/lithium-codegen-mips.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +12 lines, -3 lines 0 comments Download
M src/mips/lithium-mips.h View 1 chunk +12 lines, -2 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
7 years, 9 months ago (2013-03-10 22:11:48 UTC) #1
mvstanton
lgtm
7 years, 9 months ago (2013-03-12 09:05:37 UTC) #2
palfia
7 years, 9 months ago (2013-03-13 16:38:05 UTC) #3
Committed by Michael as r13910.

Powered by Google App Engine
This is Rietveld 408576698