Issue 12414007: Cleanup generation of type argument representations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12414007: Cleanup generation of type argument representations. (Closed)

Created:
7 years, 9 months ago by karlklose

Modified:
7 years, 9 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cleanup generation of type argument representations. Committed: https://code.google.com/p/dart/source/detail?r=19609

Patch Set 1 #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -19 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View		4 chunks	+14 lines, -19 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/12414007/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/12414007/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode2607 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2607: } Move the code below in the else ...

7 years, 9 months ago (2013-03-07 10:13:57 UTC) #2

karlklose

Thanks, Nicolas. https://codereview.chromium.org/12414007/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/12414007/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode2607 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2607: } It is in the else part.

7 years, 9 months ago (2013-03-07 11:22:18 UTC) #3

karlklose

7 years, 9 months ago (2013-03-07 11:23:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19609 (presubmit successful).

Expand Messages | Collapse Messages