Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Issue 12414005: Add MODIFY_AUDIO_SETTINGS permission in Android manifest and implementation in opensl. (Closed)

Created:
7 years, 9 months ago by leozwang1
Modified:
7 years, 9 months ago
Reviewers:
Yaron
CC:
chromium-reviews, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, bulach+watch_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, jochen+watch_chromium.org, frankf+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://src.chromium.org/svn/trunk/src/
Visibility:
Public.

Description

Add MODIFY_AUDIO_SETTINGS permission in Android manifest and implementation in opensl. MODIFY_AUDIO_SETTINGS allows application to be able to configure audio settings. In opensl back end, a function SetAudioMode is added to set audio mode for webrtc. BUG=180328

Patch Set 1 #

Patch Set 2 : Add MODIFY_AUDIO_SETTINGS and implementation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -3 lines) Patch
chrome/android/testshell/java/AndroidManifest.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/android/browsertests_apk/AndroidManifest.xml View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/android/shell_apk/AndroidManifest.xml View 1 1 chunk +2 lines, -1 line 0 comments Download
media/audio/android/opensles_output.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M media/audio/android/opensles_output.cc View 1 2 chunks +42 lines, -0 lines 0 comments Download
M testing/android/AndroidManifest.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
leozwang1
please take a look.
7 years, 9 months ago (2013-03-05 06:14:16 UTC) #1
Yaron
On 2013/03/05 06:14:16, leozwang1 wrote: > please take a look. 1. This needs an associated ...
7 years, 9 months ago (2013-03-05 17:44:30 UTC) #2
leozwang1
This could could have been done in a more organized way, we're improving it. Please ...
7 years, 9 months ago (2013-03-05 20:58:57 UTC) #3
Yaron
7 years, 9 months ago (2013-03-06 03:10:39 UTC) #4
I'd prefer to wait until the other patch is ready to land. We should only add
permissions when we need them.

Powered by Google App Engine
This is Rietveld 408576698