Add a MailNotifier that notifies chrome-security-sheriff@grotations.appspotmail.com for LKGR builds.

Add a MailNotifier that notifies chrome-security-sheriff@grotations.appspotmail.com for LKGR builds.

R=inferno@chromium.org,mbarbella@chromium.org,tandrii@google.com
TBR=glider@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296801

[inferno, 2015-07-21 04:21:42]

inferno@chromium.org changed reviewers:
+ iannucci@chromium.org

[inferno, 2015-07-21 04:22:36]

lgtm with nits

+cc Robert as an fyi. Does the params look ok ?

https://codereview.chromium.org/1241393002/diff/1/masters/master.chromium.lkg...
File masters/master.chromium.lkgr/master.cfg (right):

https://codereview.chromium.org/1241393002/diff/1/masters/master.chromium.lkg...
masters/master.chromium.lkgr/master.cfg:56: subject='LKGR build failing on
%(builder)s',
s/failing/failure

https://codereview.chromium.org/1241393002/diff/1/masters/master.chromium.lkg...
masters/master.chromium.lkgr/master.cfg:57:
extraRecipients=['chrome-security-bugs--@google.com'],
We shouldn't use this email. This is also subscribed by a lot of chrome-security
folks. Please instead use chrome-security-sheriff@grotations.appspotmail.com
[also this a sheriff's responsibility]. Wait from response from my test email.

[Oliver Chang, 2015-07-21 04:36:02]

https://codereview.chromium.org/1241393002/diff/1/masters/master.chromium.lkg...
File masters/master.chromium.lkgr/master.cfg (right):

https://codereview.chromium.org/1241393002/diff/1/masters/master.chromium.lkg...
masters/master.chromium.lkgr/master.cfg:56: subject='LKGR build failing on
%(builder)s',
On 2015/07/21 04:22:35, inferno wrote:
> s/failing/failure

Done.

https://codereview.chromium.org/1241393002/diff/1/masters/master.chromium.lkg...
masters/master.chromium.lkgr/master.cfg:57:
extraRecipients=['chrome-security-bugs--@google.com'],
On 2015/07/21 04:22:35, inferno wrote:
> We shouldn't use this email. This is also subscribed by a lot of
chrome-security
> folks. Please instead use
mailto:chrome-security-sheriff@grotations.appspotmail.com
> [also this a sheriff's responsibility]. Wait from response from my test email.

Done.

[Alexander Potapenko, 2015-07-21 08:56:39]

LGTM

[inferno, 2015-07-21 15:05:55]

lgtm

[iannucci, 2015-07-21 15:51:25]

iannucci@chromium.org changed reviewers:
+ stip@chromium.org

[iannucci, 2015-07-21 15:51:26]

stip, I think there's a better way to do this now (e.g. gatekeeper ng) that
doesn't require a master restart, right?

[inferno, 2015-07-24 05:15:26]

On 2015/07/21 15:51:26, iannucci wrote:
> stip, I think there's a better way to do this now (e.g. gatekeeper ng) that
> doesn't require a master restart, right?

friendly ping Mike

[ghost stip (do not use), 2015-07-31 20:49:44]

see https://codereview.chromium.org/1271613002

[Oliver Chang, 2015-07-31 21:05:42]

On 2015/07/31 20:49:44, stip wrote:
> see https://codereview.chromium.org/1271613002

Thanks!

[Oliver Chang, 2015-09-21 18:16:18]

+tandrii as the gatekeeper config didn't work :(

Andrii, could you please take a look to make sure this looks fine?

[Oliver Chang, 2015-09-21 18:17:36]

ochang@chromium.org changed reviewers:
+ tandrii@chromium.org

[Oliver Chang, 2015-09-21 18:17:52]

oops, didn't +tandrii properly.

[tandrii_google, 2015-09-21 23:23:27]

tandrii@google.com changed reviewers:
+ tandrii@google.com

[tandrii_google, 2015-09-21 23:23:28]

to add background to my lgtm:

there seem to be a problem with new gatekeeper-ng, which somehow doesn't send
emails. As nobody looks into it short term, I approve this CL.

[Oliver Chang, 2015-09-21 23:26:17]

The CQ bit was checked by ochang@chromium.org

[commit-bot: I haz the power, 2015-09-21 23:26:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1241393002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1241393002/20001

[commit-bot: I haz the power, 2015-09-21 23:29:09]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296801

[iannucci, 2015-09-21 23:47:33]

On 2015/09/21 at 23:23:28, tandrii wrote:
> to add background to my lgtm:
> 
> there seem to be a problem with new gatekeeper-ng, which somehow doesn't send
emails. As nobody looks into it short term, I approve this CL.

Thus guaranteeing that it will never be fixed? Is there even a bug?

[tandrii(chromium), 2015-09-22 18:30:00]

On 2015/09/21 23:47:33, iannucci wrote:
> On 2015/09/21 at 23:23:28, tandrii wrote:
> > to add background to my lgtm:
> > 
> > there seem to be a problem with new gatekeeper-ng, which somehow doesn't
send
> emails. As nobody looks into it short term, I approve this CL.
> 
> Thus guaranteeing that it will never be fixed? Is there even a bug?

Postponing the fix - yes, but I am certain go/luci is a guarantee it will be
fixed.
There are a bunch of related emails reports, unfortunately. 
What's common is difficulty to re-produce this (at least for me), hence fix. So
i filed
http://crbug.com/534904 .