Settings Rewrite: Make a common settings-section component.

chrome/browser/resources/settings/advanced_page/advanced_page.html

Index: chrome/browser/resources/settings/advanced_page/advanced_page.html
diff --git a/chrome/browser/resources/settings/advanced_page/advanced_page.html b/chrome/browser/resources/settings/advanced_page/advanced_page.html
index 3d7e79c2afa6985bab19e81915494f30ddca0ddb..a20c49fac8f8a05ebbfd90a4c56468d0379f7dc3 100644
--- a/chrome/browser/resources/settings/advanced_page/advanced_page.html
+++ b/chrome/browser/resources/settings/advanced_page/advanced_page.html
@@ -1,25 +1,43 @@
 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
 <link rel="import" href="chrome://md-settings/a11y_page/a11y_page.html">
-<link rel="import" href="chrome://md-settings/date_time_page/date_time_page.html">
 <link rel="import" href="chrome://md-settings/downloads_page/downloads_page.html">
 <link rel="import" href="chrome://md-settings/privacy_page/privacy_page.html">
+<link rel="import" href="chrome://md-settings/settings_page/settings_section.html">
 <link rel="import" href="chrome://md-settings/sync_page/sync_page.html">
 
+<if expr="chromeos">
+<link rel="import" href="chrome://md-settings/date_time_page/date_time_page.html">
+</if>
+
 <dom-module id="cr-settings-advanced-page">
-  <link rel="import" type="css"
-      href="chrome://md-settings/settings_page/settings_page.css">
   <template>
 <if expr="chromeos">
-    <cr-settings-date-time-page prefs="{{prefs}}" route="dateTime">
-    </cr-settings-date-time-page>
+    <cr-settings-section route="dateTime" icon="device:access-time"
+        i18n-values="page-title:dateTimePageTitle">

[Dan Beam, 2015/07/23 18:33:08]

why not pageTitle instead of page-title?

[tommycli, 2015/07/23 19:00:43]

Hey. 'pageTitle' doesn't work. I believe that Polymer expects the attribute
parameters to be 'hyphen-space' and maps that to 'camelCase' attributes.

+      <cr-settings-date-time-page prefs="{{prefs}}">
+      </cr-settings-date-time-page>
+    </cr-settings-section>
 </if>
-    <cr-settings-privacy-page prefs="{{prefs}}" route="privacy">
-    </cr-settings-privacy-page>
-    <cr-settings-downloads-page prefs="{{prefs}}" route="downloads">
-    </cr-settings-downloads-page>
-    <cr-settings-a11y-page prefs="{{prefs}}" route="a11y">
-    </cr-settings-a11y-page>
-    <cr-settings-sync-page route="sync"></cr-settings-sync-page>
+    <cr-settings-section route="privacy" icon="lock"
+        i18n-values="page-title:privacyPageTitle">
+      <cr-settings-privacy-page prefs="{{prefs}}"></cr-settings-privacy-page>
+    </cr-settings-section>
+
+    <cr-settings-section route="downloads" icon="file-download"
+        i18n-values="page-title:downloadsPageTitle">
+      <cr-settings-downloads-page prefs="{{prefs}}">
+      </cr-settings-downloads-page>
+    </cr-settings-section>
+
+    <cr-settings-section route="a11y" icon="accessibility"
+        i18n-values="page-title:a11yPageTitle">
+      <cr-settings-a11y-page prefs="{{prefs}}"></cr-settings-a11y-page>
+    </cr-settings-section>
+
+    <cr-settings-section route="sync" icon="notification:sync"
+        i18n-values="page-title:syncPageTitle">
+      <cr-settings-sync-page></cr-settings-sync-page>
+    </cr-settings-section>
   </template>
   <script src="advanced_page.js"></script>
 </dom-module>