Settings Rewrite: Make a common settings-section component.

chrome/browser/resources/settings/settings_page/settings_section.js

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/**
+ * @fileoverview
+ * 'cr-settings-section' shows a paper material themed section with a header
+ * which shows its page title and icon.
+ *
+ * Example:
+ *
+ *    <cr-settings-section page-title="[[pageTitle]]", icon="[[icon]]">

[michaelpg, 2015/07/22 21:01:32]

no comma

[tommycli, 2015/07/22 23:54:38]

Done.

+ *      <!-- Insert your section controls here -->
+ *    </cr-settings-section>
+ *
+ * @group Chrome Settings Elements
+ * @element cr-settings-section
+ */
+Polymer({
+  is: 'cr-settings-section',
+
+  ready: function() {
+    // We use this trickery to retrieve the content page's title and icon, as
+    // Polymer does not support directly binding content element properties.
+    var contentElement = this.getContentChildren()[0];
+    if (contentElement !== undefined &&

[michaelpg, 2015/07/22 21:01:32]

nit: use != instead of !==

[tommycli, 2015/07/22 23:54:37]

Deleted this.

+        contentElement.properties !== undefined) {
+      // Page title value is defined as a function.
+      this.pageTitle = contentElement.properties.pageTitle.value();

[michaelpg, 2015/07/22 21:01:32]

this means updating a page's pageTitle or icon has no effect. I can't say for
sure that we wouldn't want to do that. We could add our own observer I guess.

dbeam@, does this look ok to you or is it too indirect?

[michaelpg, 2015/07/22 21:01:32]

does contentElement.pageTitle not work?

[Dan Beam, 2015/07/22 21:56:31]

^ this

[Dan Beam, 2015/07/22 21:56:31]

why are we duplicating the title to begin with?  can't we just have a parent
property or id?

[Dan Beam, 2015/07/22 22:03:07]

scratch the parent part, thought this was a subpage

[tommycli, 2015/07/22 23:54:37]

Deleted this.

[tommycli, 2015/07/22 23:54:38]

Deleted this.

+      // Icon value is defined as a property.
+      this.icon = contentElement.properties.icon.value;
+    }
+  }
+});