chrome/browser/resources/settings/settings_page/settings_section.html - Issue 1241363002: Settings Rewrite: Make a common settings-section component.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_section.html

Issue 1241363002: Settings Rewrite: Make a common settings-section component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0300-webui-settings-structure

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/internet_page/internet_page.html ('K') | « chrome/browser/resources/settings/settings_page/settings_section.css ('k') | chrome/browser/resources/settings/settings_page/settings_section.js » ('j') | chrome/browser/resources/settings/settings_page/settings_section.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-material/paper-ma terial.html">

	4

	5 <dom-module id="cr-settings-section">

	6 <link rel="import" type="css" href="settings_section.css">

	7 <template>

	8 <paper-material>

	9 <div class="header">

	10 <iron-icon icon="{{icon}}"></iron-icon>

	11 <div class="title">{{pageTitle}}</div>
	Dan Beam 2015/07/22 23:12:17 if this makes someone happy I suppose that's OK an if this makes someone happy I suppose that's OK and less duplicative, but I think enforcing a hierarchy is brittle and results in lots of optional parameters added later just allowing each section to define their icon/title (the OPPOSITE of this) is fine with me. we can just do this until one of the mocks breaks these assumptions ;) tommycli 2015/07/22 23:54:38 Acknowledged. Show quoted text On 2015/07/22 23:12:17, Dan Beam wrote: > if this makes someone happy I suppose that's OK and less duplicative, but I > think enforcing a hierarchy is brittle and results in lots of optional > parameters added later > > just allowing each section to define their icon/title (the OPPOSITE of this) is > fine with me. > > we can just do this until one of the mocks breaks these assumptions ;) Acknowledged.
	12 </div>

	13 <div class="content-container">

	14 <content id="content"></content>

	15 </div>

	16 </paper-material>

	17 </template>

	18 <script src="settings_section.js"></script>

	19 </dom-module>

OLD	NEW