chrome/browser/resources/settings/basic_page/basic_page.html - Issue 1241363002: Settings Rewrite: Make a common settings-section component.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/basic_page/basic_page.html

Issue 1241363002: Settings Rewrite: Make a common settings-section component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0300-webui-settings-structure

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/appearance_page/appearance_page.html ('k') | chrome/browser/resources/settings/date_time_page/date_time_page.html » ('j') | chrome/browser/resources/settings/internet_page/internet_page.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">	1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

2 <link rel="import" href="chrome://md-settings/appearance_page/appearance_page.ht ml">	2 <link rel="import" href="chrome://md-settings/appearance_page/appearance_page.ht ml">

	3 <link rel="import" href="chrome://md-settings/search_page/search_page.html">

	4 <link rel="import" href="chrome://md-settings/settings_page/settings_section.htm l">

	5

	6 <if expr="chromeos">

3 <link rel="import" href="chrome://md-settings/internet_page/internet_page.html">	7 <link rel="import" href="chrome://md-settings/internet_page/internet_page.html">

4 <link rel="import" href="chrome://md-settings/search_page/search_page.html">

5 <link rel="import" href="chrome://md-settings/users_page/users_page.html">	8 <link rel="import" href="chrome://md-settings/users_page/users_page.html">

	9 </if>

6	10

7 <dom-module id="cr-settings-basic-page">	11 <dom-module id="cr-settings-basic-page">

8 <link rel="import" type="css"

9 href="chrome://md-settings/settings_page/settings_page.css">

10 <template>	12 <template>

11 <if expr="chromeos">	13 <if expr="chromeos">

12 <cr-settings-internet-page route="internet">	14 <cr-settings-section route="internet">
	Dan Beam 2015/07/22 23:12:17 why is the route here? why is the route here? tommycli 2015/07/22 23:54:38 Per our discussion, I think we should just keep it Show quoted text On 2015/07/22 23:12:17, Dan Beam wrote: > why is the route here? Per our discussion, I think we should just keep it here.
13 </cr-settings-internet-page>	15 <cr-settings-internet-page></cr-settings-internet-page>

	16 </cr-settings-section>

14 </if>	17 </if>

15 <cr-settings-appearance-page prefs="{{prefs}}" route="appearance">	18 <cr-settings-section route="appearance">

16 </cr-settings-appearance-page>	19 <cr-settings-appearance-page prefs="{{prefs}}">

17 <cr-settings-search-page route="search"></cr-settings-search-page>	20 </cr-settings-appearance-page>

18 <cr-settings-users-page prefs="{{prefs}}" route="users">	21 </cr-settings-section>

19 </cr-settings-users-page>	22

	23 <cr-settings-section route="search">

	24 <cr-settings-search-page></cr-settings-search-page>

	25 </cr-settings-section>

	26

	27 <if expr="chromeos">

	28 <cr-settings-section route="users">

	29 <cr-settings-users-page prefs="{{prefs}}"></cr-settings-users-page>

	30 </cr-settings-section>

	31 </if>

20 </template>	32 </template>

21 <script src="basic_page.js"></script>	33 <script src="basic_page.js"></script>

22 </dom-module>	34 </dom-module>

OLD	NEW