Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipes/gatekeeper.py

Issue 1241323004: Cross-repo recipe package system. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Change to googlesource Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« scripts/slave/recipes/blink_trybot.py ('K') | « scripts/slave/recipes/dart/dartium_perf.py ('k') | scripts/slave/recipes/gatekeeper.expected/real.json » ('j') | scripts/slave/unittests/recipe_lint_test.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/gatekeeper.py
diff --git a/scripts/slave/recipes/gatekeeper.py b/scripts/slave/recipes/gatekeeper.py
index f3110a5ed44977a7ab5a81b25d36ee30d59736d6..a09b5feddbf2a48d66196d2f035f7da4e6dd3607 100644
--- a/scripts/slave/recipes/gatekeeper.py
+++ b/scripts/slave/recipes/gatekeeper.py
@@ -19,10 +19,6 @@ def RunSteps(api):
def GenTests(api):
- # It is okay to use os here because we are reading the file immediately
- # on the simulating machine.
iannucci 2015/09/15 00:10:48 lol. May want to ping stip about this?
- import os
-
yield (
api.test('basic')
+ api.step_data(
@@ -32,16 +28,6 @@ def GenTests(api):
)
yield (
- api.test('real')
- + api.step_data(
- 'reading gatekeeper_trees.json',
- api.gatekeeper.read_real_config(
- os.path.join('scripts', 'slave', 'gatekeeper_trees.json')
- ),
- )
- )
-
- yield (
api.test('keep_going')
+ api.step_data(
'reading gatekeeper_trees.json',
« scripts/slave/recipes/blink_trybot.py ('K') | « scripts/slave/recipes/dart/dartium_perf.py ('k') | scripts/slave/recipes/gatekeeper.expected/real.json » ('j') | scripts/slave/unittests/recipe_lint_test.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698