third_party/recipe_engine/recipe_modules/json/api.py - Issue 1241323004: Cross-repo recipe package system.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/recipe_engine/recipe_modules/json/api.py

Issue 1241323004: Cross-repo recipe package system. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Moved show_me_the_modules into recipe_engine Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import functools	5 import functools

6 import collections	6 import collections

7 import contextlib	7 import contextlib

8 import json	8 import json

9	9

10 from recipe_engine import recipe_api	10 from recipe_engine import recipe_api

(...skipping 102 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
113	113

114 It's vastly preferable to have your recipe only pass the bare minimum	114 It's vastly preferable to have your recipe only pass the bare minimum

115 of arguments to steps. Passing property objects obscures the data that	115 of arguments to steps. Passing property objects obscures the data that

116 the script actually consumes from the property object.	116 the script actually consumes from the property object.

117 """	117 """

118 prop_str = self.dumps(dict(self.m.properties.legacy()))	118 prop_str = self.dumps(dict(self.m.properties.legacy()))

119 return [	119 return [

120 '--factory-properties', prop_str,	120 '--factory-properties', prop_str,

121 '--build-properties', prop_str	121 '--build-properties', prop_str

122 ]	122 ]

OLD	NEW