Issue 12413030: Removed the "any" command from the displacement glsl shader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12413030: Removed the "any" command from the displacement glsl shader. (Closed)

Created:
7 years, 9 months ago by sugoi1

Modified:
7 years, 9 months ago

Reviewers:
sugoi, senorblanco

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Removed the "any" command from the displacement glsl shader. WebKit's version of Mesa's compiler seems to crash on the "any" command even though it's a GLSL 1.1 command. Committed: https://code.google.com/p/skia/source/detail?r=8300

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	src/effects/SkDisplacementMapEffect.cpp	View		3 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sugoi1

7 years, 9 months ago (2013-03-21 18:38:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r8300 (presubmit successful).

Expand Messages | Collapse Messages