Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 12413027: Mark non-isolatified profiler API as V8_DEPRECATED (Closed)

Created:
7 years, 9 months ago by yurys
Modified:
7 years, 8 months ago
Reviewers:
Jakob Kummerow, alph, loislo
CC:
chromium-reviews
Visibility:
Public.

Description

Mark non-isolatified profiler API as V8_DEPRECATED BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=14216

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Removed test for deprecated API #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -58 lines) Patch
M include/v8-profiler.h View 12 chunks +26 lines, -23 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 2 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
7 years, 8 months ago (2013-04-08 15:57:12 UTC) #1
yurys
Now that Chromium uses only isolatified profiler methods we can mark old ones as deprecated.
7 years, 8 months ago (2013-04-08 15:57:53 UTC) #2
loislo
lgtm
7 years, 8 months ago (2013-04-08 17:13:28 UTC) #3
Jakob Kummerow
lgtm
7 years, 8 months ago (2013-04-09 08:48:33 UTC) #4
yurys
7 years, 8 months ago (2013-04-10 15:29:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r14216 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698