Issue 12413017: [nacltoons] Reference resources directly from checkout location

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12413017: [nacltoons] Reference resources directly from checkout location (Closed)

Created:
7 years, 9 months ago by Sam Clegg

Modified:
7 years, 9 months ago

Reviewers:
noelallen1, binji

CC:
native-client-reviews_googlegroups.com

Base URL:
https://nativeclient-sdk.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

[nacltoons] Reference resources directly from checkout location This allows editing of files in-place to take effect without re-publishing. Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1532

Patch Set 1 #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -14 lines)			Patch
	M	nacltoons/Makefile	View		3 chunks	+3 lines, -14 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

binji

lgtm https://codereview.chromium.org/12413017/diff/1/nacltoons/Makefile File nacltoons/Makefile (right): https://codereview.chromium.org/12413017/diff/1/nacltoons/Makefile#newcode45 nacltoons/Makefile:45: cp data/*.* $(PUBLISH_DIR) why not just data/*? also, ...

7 years, 9 months ago (2013-03-12 23:57:36 UTC) #2

Sam Clegg

https://codereview.chromium.org/12413017/diff/1/nacltoons/Makefile File nacltoons/Makefile (right): https://codereview.chromium.org/12413017/diff/1/nacltoons/Makefile#newcode45 nacltoons/Makefile:45: cp data/*.* $(PUBLISH_DIR) On 2013/03/12 23:57:36, binji wrote: > ...

7 years, 9 months ago (2013-03-13 00:45:51 UTC) #3

Sam Clegg

7 years, 9 months ago (2013-03-13 00:48:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r1532 (presubmit successful).

Expand Messages | Collapse Messages