Issue 12413002: Have FullscreenExitBubbleViews use BubbleDelegateView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12413002: Have FullscreenExitBubbleViews use BubbleDelegateView. (Closed)

Created:
7 years, 9 months ago by msw

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Have FullscreenExitBubbleViews use BubbleDelegateView. BUG=

Patch Set 1 : Have FullscreenExitBubbleViews use BubbleDelegateView. #

Patch Set 2 : Add ClippedBubbleFrameView, getting it working. #

Patch Set 3 : Clipping working with debug code. #

Patch Set 4 : Remove debugging code; working as intended. #

Patch Set 5 : Use the proper display bounds for clipping the bubble. #

Patch Set 6 : Working on Windows bubble placement and clipping. #

Patch Set 7 : TESTING #

Patch Set 8 : TESTING #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+142 lines, -115 lines)			Patch
chrome/browser/ui/views/frame/browser_view.cc	View	1 2 3 4 5 6	2 chunks	+2 lines, -2 lines	0 comments	Download
chrome/browser/ui/views/fullscreen_exit_bubble_views.h	View	1 2 3 4	2 chunks	+15 lines, -15 lines	0 comments	Download
chrome/browser/ui/views/fullscreen_exit_bubble_views.cc	View	1 2 3 4 6	10 chunks	+125 lines, -98 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

msw

4 years, 5 months ago (2016-07-06 19:10:11 UTC) #1

Description was changed from

==========
Have FullscreenExitBubbleViews use BubbleDelegateView.


BUG=
==========

to

==========
Have FullscreenExitBubbleViews use BubbleDelegateView.


BUG=
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages