Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 12413002: Have FullscreenExitBubbleViews use BubbleDelegateView. (Closed)

Created:
7 years, 9 months ago by msw
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Have FullscreenExitBubbleViews use BubbleDelegateView. BUG=

Patch Set 1 : Have FullscreenExitBubbleViews use BubbleDelegateView. #

Patch Set 2 : Add ClippedBubbleFrameView, getting it working. #

Patch Set 3 : Clipping working with debug code. #

Patch Set 4 : Remove debugging code; working as intended. #

Patch Set 5 : Use the proper display bounds for clipping the bubble. #

Patch Set 6 : Working on Windows bubble placement and clipping. #

Patch Set 7 : TESTING #

Patch Set 8 : TESTING #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -115 lines) Patch
chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
chrome/browser/ui/views/fullscreen_exit_bubble_views.h View 1 2 3 4 2 chunks +15 lines, -15 lines 0 comments Download
chrome/browser/ui/views/fullscreen_exit_bubble_views.cc View 1 2 3 4 6 10 chunks +125 lines, -98 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
msw
4 years, 5 months ago (2016-07-06 19:10:11 UTC) #1
Description was changed from

==========
Have FullscreenExitBubbleViews use BubbleDelegateView.


BUG=
==========

to

==========
Have FullscreenExitBubbleViews use BubbleDelegateView.


BUG=
==========

Powered by Google App Engine
This is Rietveld 408576698