Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1241263004: Change "open image" context menu link transtion type to LINK (Closed)

Created:
5 years, 5 months ago by Theresa
Modified:
5 years, 5 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change "open image" context menu link transtion type to LINK Use PageTransition.LINK when "open image" or "open image in new tab" is selected from the context menu. BUG=505430 Committed: https://crrev.com/db484c3eff68c46ddf1530dd60441dba4614cb5c Cr-Commit-Position: refs/heads/master@{#339752}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Theresa
ptal
5 years, 5 months ago (2015-07-21 20:45:16 UTC) #2
newt (away)
lgtm
5 years, 5 months ago (2015-07-21 20:46:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241263004/1
5 years, 5 months ago (2015-07-21 21:29:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 21:35:23 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 21:36:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db484c3eff68c46ddf1530dd60441dba4614cb5c
Cr-Commit-Position: refs/heads/master@{#339752}

Powered by Google App Engine
This is Rietveld 408576698