Issue 124123002: Fix buildbot upload of vs_addin archive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 124123002: Fix buildbot upload of vs_addin archive. (Closed)

Created:
6 years, 11 months ago by Sam Clegg

Modified:
6 years, 11 months ago

Reviewers:
binji

CC:
native-client-reviews_googlegroups.com

Base URL:
https://nativeclient-sdk.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

Fix buildbot upload of vs_addin archive. This change adddresses a couple of issues with the upload of the vs_addin archive to google storage. Firstly is disables the upload step for periodic builders so that they don't clobber existing uploads. Secondly we check for the existence of a file on google storage before uploading and error out if one is already found. R=binji@chromium.org Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1569

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -25 lines)			Patch
	M	visual_studio/NativeClientVSAddIn/buildbot_run.py	View		5 chunks	+41 lines, -25 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sam Clegg

6 years, 11 months ago (2014-01-03 22:56:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r1569 (presubmit successful).

Expand Messages | Collapse Messages