Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 12412021: Don't hardcode Python path (Closed)

Created:
7 years, 9 months ago by Ramkumar Ramachandra
Modified:
7 years, 9 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Don't hardcode Python path Instead of hardcoding /usr/bin/python, which might be set to point to Python3 for many users, execute `/usr/bin/env python` in the she-bang; users simply need to be instructed to make sure that this points to Python2. Committed: https://code.google.com/p/naclports/source/detail?r=713

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M build_tools/download_sdk.py View 1 chunk +1 line, -1 line 0 comments Download
M build_tools/sha1check.py View 1 chunk +1 line, -1 line 0 comments Download
M build_tools/sha1sum.py View 1 chunk +1 line, -1 line 0 comments Download
M experimental/libav/voronoi/run.py View 1 chunk +1 line, -1 line 0 comments Download
M experimental/quake/httpd.py View 1 chunk +1 line, -1 line 0 comments Download
M httpd.py View 1 chunk +1 line, -1 line 0 comments Download
M libraries/nacl-mounts/AppEngine/AppEngineMount.py View 1 chunk +1 line, -1 line 0 comments Download
M libraries/nacl-mounts/http2/genfs.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ramkumar Ramachandra
Hi, Could you please review this simple change? I ran into the issue while trying ...
7 years, 9 months ago (2013-03-14 09:19:56 UTC) #1
Sam Clegg
LGTM, thanks! Might be a good idea to also add these three lines to top ...
7 years, 9 months ago (2013-03-14 15:56:39 UTC) #2
artagnon_gmail.com
Hi, <sbc@chromium.org> wrote: > LGTM, thanks! Thanks, but I don't have commit access to check ...
7 years, 9 months ago (2013-03-15 06:55:33 UTC) #3
Sam Clegg
7 years, 9 months ago (2013-03-19 00:12:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r713 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698