Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 12412020: drive: Include "include-shared=true" for including shared resources in feeds. (Closed)

Created:
7 years, 9 months ago by kinaba
Modified:
7 years, 9 months ago
Reviewers:
Haruki Sato, tzik
CC:
chromium-reviews, achuith+watch_chromium.org
Visibility:
Public.

Description

drive: Include "include-shared=true" for including shared resources in feeds. There's no visible change yet, because we are currently ignoring resources that do not belong to the hierarchy rooted at "My Drive". This is for preparation of the coming feature to support "shared-with-me" tab in the Chrome OS Files.app. BUG=189087 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188299

Patch Set 1 : #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -16 lines) Patch
M chrome/browser/google_apis/gdata_wapi_operations_unittest.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_url_generator.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_url_generator_unittest.cc View 10 chunks +16 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinaba
+haruki, this is the latter half for 189087. ptal. (I've verified it working by embedding ...
7 years, 9 months ago (2013-03-14 06:25:04 UTC) #1
tzik
On 2013/03/14 06:25:04, kinaba wrote: > +haruki, this is the latter half for 189087. ptal. ...
7 years, 9 months ago (2013-03-14 06:28:39 UTC) #2
Haruki Sato
lgtm Thanks!
7 years, 9 months ago (2013-03-14 10:05:38 UTC) #3
kinaba
7 years, 9 months ago (2013-03-15 08:21:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r188299 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698