chrome/android/java/res/layout/autofill_dialog_content.xml - Issue 12412003: Initial UI structure for autofill dialog

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/autofill_dialog_content.xml

Issue 12412003: Initial UI structure for autofill dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixes to comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/android/java/res/layout/autofill_cc_spinner_dropdown.xml ('k') | chrome/android/java/res/layout/autofill_dialog_title.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright (c) 2013 The Chromium Authors. All rights reserved.

	3

	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7 <org.chromium.chrome.browser.autofill.AutofillDialogContentView xmlns:android="h ttp://schemas.android.com/apk/res/android"

	8 android:layout_width="wrap_content"

	9 android:layout_height="wrap_content">

	10 <!--TODO(yusufo):Add accessibility content description for all actionable it ems-->

	11 <include layout="@layout/autofill_general_layout"/>

	12 <include layout="@layout/autofill_editing_layout_shipping"/>

	13 <include layout="@layout/autofill_editing_layout_billing"/>

	14 <LinearLayout

	15 android:layout_width="match_parent"

	16 android:layout_height="match_parent"

	17 android:id="@+id/loading_icon"

	18 android:visibility="gone"

	19 android:gravity="center"

	20 android:orientation="vertical">

	21 <ProgressBar

	22 android:layout_marginTop="30dp"

	23 android:layout_width="48dp"
	Ted C 2013/03/07 18:28:09 is this meant to match @dimen/autofill_edit_height is this meant to match @dimen/autofill_edit_height? Or is it just coincidence? Just wondering if you should use the constant or not. Yusuf 2013/03/07 18:53:20 It is a coincidence. I think we will end up gettin It is a coincidence. I think we will end up getting a different spec for this. On 2013/03/07 18:28:09, Ted C wrote: Show quoted text > is this meant to match @dimen/autofill_edit_height? Or is it just coincidence? > Just wondering if you should use the constant or not.
	24 android:layout_height="48dp"

	25 android:indeterminate="true"/>

	26 <TextView

	27 android:layout_margin="20dp"

	28 android:layout_width="wrap_content"

	29 android:layout_height="wrap_content"

	30 android:text="@string/autofill_fetch_message" />

	31 </LinearLayout>

	32 </org.chromium.chrome.browser.autofill.AutofillDialogContentView>

OLD	NEW