Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1241173004: Move extern fpdf_font_charset.cpp function prototypes to header (Closed)

Created:
5 years, 5 months ago by Tom Sepez
Modified:
5 years, 5 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move extern fpdf_font_charset.cpp function prototypes to header. Make others static while we're at it. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/c5fa7f2a36ebd4c92c935e1332a2f7db4f3594d9

Patch Set 1 #

Patch Set 2 : Missed one. #

Total comments: 2

Patch Set 3 : 80 cols #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -35 lines) Patch
M core/include/fpdfapi/fpdf_resource.h View 1 2 3 chunks +13 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 4 chunks +4 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_charset.cpp View 16 chunks +21 lines, -20 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 1 chunk +6 lines, -5 lines 0 comments Download
M core/src/fpdftext/fpdf_text.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
Lei.
5 years, 5 months ago (2015-07-21 22:06:05 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1241173004/diff/20001/core/include/fpdfapi/fpdf_resource.h File core/include/fpdfapi/fpdf_resource.h (right): https://codereview.chromium.org/1241173004/diff/20001/core/include/fpdfapi/fpdf_resource.h#newcode44 core/include/fpdfapi/fpdf_resource.h:44: const FX_CHAR* PDF_CharNameFromPredefinedCharSet(int encoding, uint8_t charcode); 80 chars, ...
5 years, 5 months ago (2015-07-21 23:08:05 UTC) #3
Tom Sepez
https://codereview.chromium.org/1241173004/diff/20001/core/include/fpdfapi/fpdf_resource.h File core/include/fpdfapi/fpdf_resource.h (right): https://codereview.chromium.org/1241173004/diff/20001/core/include/fpdfapi/fpdf_resource.h#newcode44 core/include/fpdfapi/fpdf_resource.h:44: const FX_CHAR* PDF_CharNameFromPredefinedCharSet(int encoding, uint8_t charcode); On 2015/07/21 23:08:05, ...
5 years, 5 months ago (2015-07-21 23:41:31 UTC) #4
Tom Sepez
5 years, 5 months ago (2015-07-21 23:41:53 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
c5fa7f2a36ebd4c92c935e1332a2f7db4f3594d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698