Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 12411007: Update help in SkFlags. (Closed)

Created:
7 years, 9 months ago by scroggo
Modified:
7 years, 9 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Update help in SkFlags. Print the short name in addition to the standard name. Allow an option for getting help for a specific command. Committed: https://code.google.com/p/skia/source/detail?r=8273

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Fix a nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -41 lines) Patch
M tools/SkFlags.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/SkFlags.cpp View 1 2 2 chunks +79 lines, -41 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scroggo
7 years, 9 months ago (2013-03-20 18:33:47 UTC) #1
borenet
LGTM https://codereview.chromium.org/12411007/diff/1003/tools/SkFlags.cpp File tools/SkFlags.cpp (right): https://codereview.chromium.org/12411007/diff/1003/tools/SkFlags.cpp#newcode106 tools/SkFlags.cpp:106: || flag->shortName().equals(helpFlags[k])) { Nit: I find it more ...
7 years, 9 months ago (2013-03-20 18:45:28 UTC) #2
scroggo
https://codereview.chromium.org/12411007/diff/1003/tools/SkFlags.cpp File tools/SkFlags.cpp (right): https://codereview.chromium.org/12411007/diff/1003/tools/SkFlags.cpp#newcode106 tools/SkFlags.cpp:106: || flag->shortName().equals(helpFlags[k])) { On 2013/03/20 18:45:28, borenet wrote: > ...
7 years, 9 months ago (2013-03-20 18:59:44 UTC) #3
scroggo
7 years, 9 months ago (2013-03-20 19:50:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r8273 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698