Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2711)

Unified Diff: chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc

Issue 1241063003: Support Component Actions in the toolbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes per mfoltz@'s comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
diff --git a/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc b/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
index 05d3dbcd551bf8c66da5b9ce84f4c7ffb28548fc..316918054f56e8e7cfa1c314809773d961e14947 100644
--- a/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
+++ b/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
@@ -6,14 +6,15 @@
#include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
#include "chrome/browser/extensions/browser_action_test_util.h"
-#include "chrome/browser/extensions/extension_toolbar_model.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/toolbar/browser_actions_bar_browsertest.h"
+#include "chrome/browser/ui/toolbar/toolbar_actions_model.h"
#include "chrome/browser/ui/views/extensions/browser_action_drag_data.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/toolbar/toolbar_action_view.h"
#include "chrome/browser/ui/views/toolbar/toolbar_view.h"
#include "extensions/browser/extension_prefs.h"
+#include "extensions/browser/extension_registry.h"
#include "extensions/common/extension.h"
#include "ui/base/dragdrop/drop_target_event.h"
#include "ui/base/dragdrop/os_exchange_data.h"
@@ -62,9 +63,15 @@ IN_PROC_BROWSER_TEST_F(BrowserActionsBarBrowserTest, DragBrowserActions) {
EXPECT_EQ(extension_c()->id(), browser_actions_bar()->GetExtensionId(2));
// This order should be reflected in the underlying model.
- EXPECT_EQ(extension_b(), toolbar_model()->toolbar_items()[0].get());
- EXPECT_EQ(extension_a(), toolbar_model()->toolbar_items()[1].get());
- EXPECT_EQ(extension_c(), toolbar_model()->toolbar_items()[2].get());
+ EXPECT_EQ(extension_b(), extensions::ExtensionRegistry::Get(
+ profile())->enabled_extensions().GetByID(
+ toolbar_model()->toolbar_items()[0]));
+ EXPECT_EQ(extension_a(), extensions::ExtensionRegistry::Get(
+ profile())->enabled_extensions().GetByID(
+ toolbar_model()->toolbar_items()[1]));
+ EXPECT_EQ(extension_c(), extensions::ExtensionRegistry::Get(
+ profile())->enabled_extensions().GetByID(
+ toolbar_model()->toolbar_items()[2]));
// Simulate a drag and drop to the left.
ui::OSExchangeData drop_data2;
@@ -181,7 +188,7 @@ IN_PROC_BROWSER_TEST_F(BrowserActionsBarBrowserTest, MultipleWindows) {
// Test that the BrowserActionsContainer responds correctly when the underlying
// model enters highlight mode, and that browser actions are undraggable in
// highlight mode. (Highlight mode itself it tested more thoroughly in the
-// ExtensionToolbarModel browsertests).
+// ToolbarActionsModel browsertests).
IN_PROC_BROWSER_TEST_F(BrowserActionsBarBrowserTest, HighlightMode) {
LoadExtensions();
@@ -198,11 +205,11 @@ IN_PROC_BROWSER_TEST_F(BrowserActionsBarBrowserTest, HighlightMode) {
gfx::Point point(action_view->x(), action_view->y());
EXPECT_TRUE(container->CanStartDragForView(action_view, point, point));
- extensions::ExtensionIdList extension_ids;
- extension_ids.push_back(extension_a()->id());
- extension_ids.push_back(extension_b()->id());
- toolbar_model()->HighlightExtensions(
- extension_ids, extensions::ExtensionToolbarModel::HIGHLIGHT_WARNING);
+ ActionIdList action_ids;
+ action_ids.push_back(extension_a()->id());
+ action_ids.push_back(extension_b()->id());
+ toolbar_model()->HighlightActions(
+ action_ids, ToolbarActionsModel::HIGHLIGHT_WARNING);
// Only two browser actions should be visible.
EXPECT_EQ(2, browser_actions_bar()->VisibleBrowserActions());
@@ -342,7 +349,7 @@ IN_PROC_BROWSER_TEST_F(BrowserActionsContainerOverflowTest,
// Move extension C to the first position. Order should now be C A B, with
// C and A visible in the main bar.
- toolbar_model()->MoveExtensionIcon(extension_c()->id(), 0);
+ toolbar_model()->MoveActionIcon(extension_c()->id(), 0);
overflow_bar()->Layout(); // Kick.
EXPECT_EQ(extension_c()->id(), main_bar()->GetIdAt(0u));
EXPECT_EQ(extension_a()->id(), main_bar()->GetIdAt(1u));

Powered by Google App Engine
This is Rietveld 408576698