Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6164)

Unified Diff: chrome/browser/ui/toolbar/media_router_action.cc

Issue 1241063003: Support Component Actions in the toolbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes per mfoltz@'s comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/media_router_action.cc
diff --git a/chrome/browser/ui/toolbar/media_router_action.cc b/chrome/browser/ui/toolbar/media_router_action.cc
index cc9425e2e29181180028cb4d9f5b94a518816b76..78c0e195c17535aa8e18e7ac076c397adaf169f7 100644
--- a/chrome/browser/ui/toolbar/media_router_action.cc
+++ b/chrome/browser/ui/toolbar/media_router_action.cc
@@ -6,6 +6,7 @@
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/media/router/media_router_dialog_controller.h"
+#include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h"
#include "chrome/browser/ui/toolbar/media_router_action_platform_delegate.h"
#include "chrome/browser/ui/toolbar/toolbar_action_view_delegate.h"
#include "chrome/grit/generated_resources.h"
@@ -17,7 +18,7 @@
using media_router::MediaRouterDialogController;
MediaRouterAction::MediaRouterAction(Browser* browser)
- : id_("media_router_action"),
+ : id_(ComponentToolbarActionsFactory::kMediaRouterActionId),
name_(l10n_util::GetStringUTF16(IDS_MEDIA_ROUTER_TITLE)),
media_router_idle_icon_(ui::ResourceBundle::GetSharedInstance().
GetImageNamed(IDR_MEDIA_ROUTER_IDLE_ICON)),
@@ -85,7 +86,7 @@ ui::MenuModel* MediaRouterAction::GetContextMenu() {
}
bool MediaRouterAction::CanDrag() const {
- return false;
+ return true;
}
bool MediaRouterAction::ExecuteAction(bool by_user) {
@@ -96,6 +97,8 @@ bool MediaRouterAction::ExecuteAction(bool by_user) {
}
void MediaRouterAction::UpdateState() {
+ if (delegate_)
+ delegate_->UpdateState();
}
MediaRouterDialogController*

Powered by Google App Engine
This is Rietveld 408576698