Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3541)

Unified Diff: chrome/browser/ui/toolbar/component_toolbar_actions_factory.h

Issue 1241063003: Support Component Actions in the toolbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Switch GetComponentActionId to unix_hacker_style. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/component_toolbar_actions_factory.h
diff --git a/chrome/browser/ui/toolbar/component_toolbar_actions_factory.h b/chrome/browser/ui/toolbar/component_toolbar_actions_factory.h
index 9a205eded0af0041ff9cc2c50c00f4958cba0811..6bdee8efc7ea1499638e2cce1363b1d7795a7461 100644
--- a/chrome/browser/ui/toolbar/component_toolbar_actions_factory.h
+++ b/chrome/browser/ui/toolbar/component_toolbar_actions_factory.h
@@ -17,28 +17,28 @@ class ToolbarActionViewController;
// components of chrome, such as ChromeCast.
class ComponentToolbarActionsFactory {
public:
+ // Component action IDs.
+ static const char kMediaRouterActionId[];
+ static const char kActionIdForTesting[]; // Only used for testing.
+
ComponentToolbarActionsFactory();
- ~ComponentToolbarActionsFactory();
+ virtual ~ComponentToolbarActionsFactory();
static ComponentToolbarActionsFactory* GetInstance();
- // Returns a collection of controllers for Chrome Actions. Declared virtual
- // for testing.
+ // Returns a vector of IDs of the component actions.
+ static std::vector<std::string> GetComponentIds();
+
+ // Returns a collection of controllers for component actions. Declared
+ // virtual for testing.
virtual ScopedVector<ToolbarActionViewController>
GetComponentToolbarActions(Browser* browser);
- // Returns the number of component actions.
- int GetNumComponentActions(Browser* browser);
-
// Sets the factory to use for testing purposes.
// Ownership remains with the caller.
static void SetTestingFactory(ComponentToolbarActionsFactory* factory);
private:
- // The number of component actions. Initially set to -1 to denote that the
- // count has not been checked yet.
- int num_component_actions_;
-
DISALLOW_COPY_AND_ASSIGN(ComponentToolbarActionsFactory);
};

Powered by Google App Engine
This is Rietveld 408576698