Chromium Code Reviews| Index: chrome/browser/ui/toolbar/component_toolbar_actions_factory.h |
| diff --git a/chrome/browser/ui/toolbar/component_toolbar_actions_factory.h b/chrome/browser/ui/toolbar/component_toolbar_actions_factory.h |
| index 9a205eded0af0041ff9cc2c50c00f4958cba0811..a8ce311238439f4c9b961bb027ef1abd979b3d3a 100644 |
| --- a/chrome/browser/ui/toolbar/component_toolbar_actions_factory.h |
| +++ b/chrome/browser/ui/toolbar/component_toolbar_actions_factory.h |
| @@ -17,18 +17,25 @@ class ToolbarActionViewController; |
| // components of chrome, such as ChromeCast. |
| class ComponentToolbarActionsFactory { |
| public: |
| + // Component action ids. |
|
Peter Kasting
2015/08/11 19:10:49
Nit: "ids" should probably still be "IDs" in the c
apacible
2015/08/12 05:26:44
Comments - Done.
For function/constant naming --
|
| + static const char kMediaRouterActionId[]; |
| + static const char kActionIdForTesting[]; // Only used for testing. |
| + |
| ComponentToolbarActionsFactory(); |
| - ~ComponentToolbarActionsFactory(); |
| + virtual ~ComponentToolbarActionsFactory(); |
| static ComponentToolbarActionsFactory* GetInstance(); |
| - // Returns a collection of controllers for Chrome Actions. Declared virtual |
| - // for testing. |
| + // Returns a vector of ids of the component actions. |
| + static scoped_ptr<std::vector<std::string>> GetComponentIds(); |
| + |
| + // Returns a collection of controllers for component actions. Declared |
| + // virtual for testing. |
| virtual ScopedVector<ToolbarActionViewController> |
| GetComponentToolbarActions(Browser* browser); |
| // Returns the number of component actions. |
| - int GetNumComponentActions(Browser* browser); |
| + int GetNumComponentActions(); |
| // Sets the factory to use for testing purposes. |
| // Ownership remains with the caller. |