Support Component Actions in the toolbar.

chrome/browser/ui/toolbar/component_toolbar_actions_factory.h

Index: chrome/browser/ui/toolbar/component_toolbar_actions_factory.h
diff --git a/chrome/browser/ui/toolbar/component_toolbar_actions_factory.h b/chrome/browser/ui/toolbar/component_toolbar_actions_factory.h
index 9a205eded0af0041ff9cc2c50c00f4958cba0811..0d64fda45633959c093ff210e82f91dac99f6f09 100644
--- a/chrome/browser/ui/toolbar/component_toolbar_actions_factory.h
+++ b/chrome/browser/ui/toolbar/component_toolbar_actions_factory.h
@@ -17,13 +17,20 @@ class ToolbarActionViewController;
 // components of chrome, such as ChromeCast.
 class ComponentToolbarActionsFactory {
  public:
+  // Component Action IDs.

[Peter Kasting, 2015/08/06 20:15:17]

Nit: Why do we capitalize "Component Action" in all the comments in this file? 
Seems like using normal sentence case would be more correct.

[apacible, 2015/08/10 22:38:11]

Made these lower case except at a beginning of a comment/sentence.

+  static const char kMediaRouterActionId[];
+  static const char kActionIdForTest[];  // Only used for testing.

[Peter Kasting, 2015/08/06 20:15:17]

Nit: ForTesting

[apacible, 2015/08/10 22:38:11]

Done.

+
   ComponentToolbarActionsFactory();
   ~ComponentToolbarActionsFactory();
 
   static ComponentToolbarActionsFactory* GetInstance();
 
-  // Returns a collection of controllers for Chrome Actions. Declared virtual
-  // for testing.
+  // Returns a list of ids of the Component Actions.

[Peter Kasting, 2015/08/06 20:15:17]

Nit: This comment is technically incorrect, since a vector is not a "list".

More interestingly, this sounds similar to GetNumComponentActions() below (I'd
expect that to return the size of this vector), but that takes a Browser* and
this doesn't, and the comments don't make the distinction clear.

[apacible, 2015/08/10 22:38:11]

Updated.

+  static std::vector<std::string> GetComponentIds();
+
+  // Returns a collection of controllers for Component Actions. Declared
+  // virtual for testing.
   virtual ScopedVector<ToolbarActionViewController>
       GetComponentToolbarActions(Browser* browser);