OLD | NEW |
1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "chrome/browser/ui/toolbar/browser_actions_bar_browsertest.h" | 5 #include "chrome/browser/ui/toolbar/browser_actions_bar_browsertest.h" |
6 | 6 |
7 #include "base/run_loop.h" | 7 #include "base/run_loop.h" |
8 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h" | 8 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h" |
9 #include "chrome/browser/extensions/browser_action_test_util.h" | 9 #include "chrome/browser/extensions/browser_action_test_util.h" |
10 #include "chrome/browser/extensions/extension_action.h" | 10 #include "chrome/browser/extensions/extension_action.h" |
11 #include "chrome/browser/extensions/extension_action_manager.h" | 11 #include "chrome/browser/extensions/extension_action_manager.h" |
12 #include "chrome/browser/extensions/extension_action_test_util.h" | 12 #include "chrome/browser/extensions/extension_action_test_util.h" |
13 #include "chrome/browser/extensions/extension_browsertest.h" | 13 #include "chrome/browser/extensions/extension_browsertest.h" |
14 #include "chrome/browser/extensions/extension_service.h" | 14 #include "chrome/browser/extensions/extension_service.h" |
15 #include "chrome/browser/extensions/extension_toolbar_model.h" | |
16 #include "chrome/browser/sessions/session_tab_helper.h" | 15 #include "chrome/browser/sessions/session_tab_helper.h" |
17 #include "chrome/browser/ui/extensions/extension_action_view_controller.h" | 16 #include "chrome/browser/ui/extensions/extension_action_view_controller.h" |
18 #include "chrome/browser/ui/tabs/tab_strip_model.h" | 17 #include "chrome/browser/ui/tabs/tab_strip_model.h" |
19 #include "chrome/browser/ui/toolbar/toolbar_action_view_controller.h" | 18 #include "chrome/browser/ui/toolbar/toolbar_action_view_controller.h" |
20 #include "chrome/browser/ui/toolbar/toolbar_actions_bar.h" | 19 #include "chrome/browser/ui/toolbar/toolbar_actions_bar.h" |
| 20 #include "chrome/browser/ui/toolbar/toolbar_actions_model.h" |
21 #include "components/crx_file/id_util.h" | 21 #include "components/crx_file/id_util.h" |
22 #include "content/public/browser/notification_service.h" | 22 #include "content/public/browser/notification_service.h" |
23 #include "content/public/test/test_utils.h" | 23 #include "content/public/test/test_utils.h" |
24 #include "extensions/browser/extension_prefs.h" | 24 #include "extensions/browser/extension_prefs.h" |
25 #include "extensions/browser/extension_registry.h" | 25 #include "extensions/browser/extension_registry.h" |
26 #include "extensions/browser/notification_types.h" | 26 #include "extensions/browser/notification_types.h" |
27 #include "extensions/common/extension.h" | 27 #include "extensions/common/extension.h" |
28 #include "extensions/common/extension_builder.h" | 28 #include "extensions/common/extension_builder.h" |
29 #include "extensions/common/value_builder.h" | 29 #include "extensions/common/value_builder.h" |
30 #include "extensions/test/extension_test_message_listener.h" | 30 #include "extensions/test/extension_test_message_listener.h" |
(...skipping 29 matching lines...) Expand all Loading... |
60 | 60 |
61 void BrowserActionsBarBrowserTest::SetUpCommandLine( | 61 void BrowserActionsBarBrowserTest::SetUpCommandLine( |
62 base::CommandLine* command_line) { | 62 base::CommandLine* command_line) { |
63 ToolbarActionsBar::disable_animations_for_testing_ = true; | 63 ToolbarActionsBar::disable_animations_for_testing_ = true; |
64 ExtensionBrowserTest::SetUpCommandLine(command_line); | 64 ExtensionBrowserTest::SetUpCommandLine(command_line); |
65 } | 65 } |
66 | 66 |
67 void BrowserActionsBarBrowserTest::SetUpOnMainThread() { | 67 void BrowserActionsBarBrowserTest::SetUpOnMainThread() { |
68 ExtensionBrowserTest::SetUpOnMainThread(); | 68 ExtensionBrowserTest::SetUpOnMainThread(); |
69 browser_actions_bar_.reset(new BrowserActionTestUtil(browser())); | 69 browser_actions_bar_.reset(new BrowserActionTestUtil(browser())); |
70 toolbar_model_ = extensions::ExtensionToolbarModel::Get(profile()); | 70 toolbar_model_ = ToolbarActionsModel::Get(profile()); |
71 } | 71 } |
72 | 72 |
73 void BrowserActionsBarBrowserTest::TearDownOnMainThread() { | 73 void BrowserActionsBarBrowserTest::TearDownOnMainThread() { |
74 ToolbarActionsBar::disable_animations_for_testing_ = false; | 74 ToolbarActionsBar::disable_animations_for_testing_ = false; |
75 ExtensionBrowserTest::TearDownOnMainThread(); | 75 ExtensionBrowserTest::TearDownOnMainThread(); |
76 } | 76 } |
77 | 77 |
78 void BrowserActionsBarBrowserTest::LoadExtensions() { | 78 void BrowserActionsBarBrowserTest::LoadExtensions() { |
79 // Create three extensions with browser actions. | 79 // Create three extensions with browser actions. |
80 extension_a_ = CreateExtension("alpha", true); | 80 extension_a_ = CreateExtension("alpha", true); |
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
140 | 140 |
141 EXPECT_EQ(3, browser_actions_bar()->VisibleBrowserActions()); | 141 EXPECT_EQ(3, browser_actions_bar()->VisibleBrowserActions()); |
142 EXPECT_EQ(3, browser_actions_bar()->NumberOfBrowserActions()); | 142 EXPECT_EQ(3, browser_actions_bar()->NumberOfBrowserActions()); |
143 | 143 |
144 // Order is now A B C. | 144 // Order is now A B C. |
145 EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(0)); | 145 EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(0)); |
146 EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(1)); | 146 EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(1)); |
147 EXPECT_EQ(extension_c()->id(), browser_actions_bar()->GetExtensionId(2)); | 147 EXPECT_EQ(extension_c()->id(), browser_actions_bar()->GetExtensionId(2)); |
148 | 148 |
149 // Move C to first position. Order is C A B. | 149 // Move C to first position. Order is C A B. |
150 toolbar_model()->MoveExtensionIcon(extension_c()->id(), 0); | 150 toolbar_model()->MoveActionIcon(extension_c()->id(), 0); |
151 EXPECT_EQ(extension_c()->id(), browser_actions_bar()->GetExtensionId(0)); | 151 EXPECT_EQ(extension_c()->id(), browser_actions_bar()->GetExtensionId(0)); |
152 EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(1)); | 152 EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(1)); |
153 EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(2)); | 153 EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(2)); |
154 | 154 |
155 // Move B to third position. Order is still C A B. | 155 // Move B to third position. Order is still C A B. |
156 toolbar_model()->MoveExtensionIcon(extension_b()->id(), 2); | 156 toolbar_model()->MoveActionIcon(extension_b()->id(), 2); |
157 EXPECT_EQ(extension_c()->id(), browser_actions_bar()->GetExtensionId(0)); | 157 EXPECT_EQ(extension_c()->id(), browser_actions_bar()->GetExtensionId(0)); |
158 EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(1)); | 158 EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(1)); |
159 EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(2)); | 159 EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(2)); |
160 | 160 |
161 // Move B to middle position. Order is C B A. | 161 // Move B to middle position. Order is C B A. |
162 toolbar_model()->MoveExtensionIcon(extension_b()->id(), 1); | 162 toolbar_model()->MoveActionIcon(extension_b()->id(), 1); |
163 EXPECT_EQ(extension_c()->id(), browser_actions_bar()->GetExtensionId(0)); | 163 EXPECT_EQ(extension_c()->id(), browser_actions_bar()->GetExtensionId(0)); |
164 EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(1)); | 164 EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(1)); |
165 EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(2)); | 165 EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(2)); |
166 } | 166 } |
167 | 167 |
168 // Test that explicitly hiding an extension action results in it disappearing | 168 // Test that explicitly hiding an extension action results in it disappearing |
169 // from the browser actions bar. | 169 // from the browser actions bar. |
170 IN_PROC_BROWSER_TEST_F(BrowserActionsBarBrowserTest, ForceHide) { | 170 IN_PROC_BROWSER_TEST_F(BrowserActionsBarBrowserTest, ForceHide) { |
171 LoadExtensions(); | 171 LoadExtensions(); |
172 | 172 |
(...skipping 340 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
513 EXPECT_EQ(page_action_extension->id(), | 513 EXPECT_EQ(page_action_extension->id(), |
514 browser_actions_bar()->GetExtensionId(0)); | 514 browser_actions_bar()->GetExtensionId(0)); |
515 browser_actions_bar()->Press(0); | 515 browser_actions_bar()->Press(0); |
516 base::RunLoop().RunUntilIdle(); | 516 base::RunLoop().RunUntilIdle(); |
517 EXPECT_TRUE(browser_actions_bar()->HasPopup()); | 517 EXPECT_TRUE(browser_actions_bar()->HasPopup()); |
518 // Cleanup the popup (to avoid having windows open at tear down). | 518 // Cleanup the popup (to avoid having windows open at tear down). |
519 browser_actions_bar()->HidePopup(); | 519 browser_actions_bar()->HidePopup(); |
520 content::RunAllBlockingPoolTasksUntilIdle(); | 520 content::RunAllBlockingPoolTasksUntilIdle(); |
521 EXPECT_FALSE(browser_actions_bar()->HasPopup()); | 521 EXPECT_FALSE(browser_actions_bar()->HasPopup()); |
522 } | 522 } |
OLD | NEW |