Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 1240993003: Revert of Make d8 stop using to-be-deprecated APIs (Closed)

Created:
5 years, 5 months ago by Michael Achenbach
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Make d8 stop using to-be-deprecated APIs (patchset #3 id:40001 of https://codereview.chromium.org/1239053004/) Reason for revert: [Sheriff] Breaks: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20code%20serializer/builds/3400 Original issue's description: > Make d8 stop using to-be-deprecated APIs > > BUG=v8:4134 > LOG=n > R=yangguo@chromium.org > > Committed: https://crrev.com/af82ef84b4f851411f00e69167ab29382c7499b8 > Cr-Commit-Position: refs/heads/master@{#29726} TBR=yangguo@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4134 Committed: https://crrev.com/8bde6b1920fd59afbea3a59d7d1fff502892fde0 Cr-Commit-Position: refs/heads/master@{#29730}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -560 lines) Patch
M src/d8.h View 9 chunks +18 lines, -17 lines 0 comments Download
M src/d8.cc View 54 chunks +218 lines, -345 lines 0 comments Download
M src/d8.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/d8-debug.cc View 4 chunks +28 lines, -49 lines 0 comments Download
M src/d8-posix.cc View 28 chunks +72 lines, -137 lines 0 comments Download
M src/d8-readline.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M src/d8-windows.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Make d8 stop using to-be-deprecated APIs
5 years, 5 months ago (2015-07-17 13:53:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240993003/1
5 years, 5 months ago (2015-07-17 13:53:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-17 13:53:45 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 13:53:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bde6b1920fd59afbea3a59d7d1fff502892fde0
Cr-Commit-Position: refs/heads/master@{#29730}

Powered by Google App Engine
This is Rietveld 408576698